From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 786101FF380 for ; Fri, 19 Apr 2024 14:54:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9D0DC947E; Fri, 19 Apr 2024 14:54:27 +0200 (CEST) Message-ID: <4ca74b0d-8008-49e2-b63b-9fa0d02885ed@proxmox.com> Date: Fri, 19 Apr 2024 14:54:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Fiona Ebner , Proxmox VE development discussion References: <20240409132555.364926-1-l.wagner@proxmox.com> <20240409132555.364926-8-l.wagner@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox 07/19] notify: api: add get_targets X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 2024-04-19 10:34, Fiona Ebner wrote: > Am 09.04.24 um 15:25 schrieb Lukas Wagner: >> +/// Get a list of all notification targets. >> +pub fn get_targets(config: &Config) -> Result, HttpError> { >> + let mut targets = Vec::new(); >> + >> + #[cfg(feature = "gotify")] >> + for endpoint in gotify::get_endpoints(config)? { >> + targets.push(Target { >> + name: endpoint.name, >> + origin: endpoint.origin.unwrap_or(Origin::UserCreated), >> + endpoint_type: EndpointType::Gotify, >> + disable: endpoint.disable, >> + comment: endpoint.comment, >> + }) > > Would it make sense to have into() functions for > {Gotify,Sendmail,Smtp}Config -> Target ? That would indeed be a bit nicer - but I'll do that in a follow-up, since this is completely internal to proxmox-notify and is more 'style' than an actual issue :) Thanks! -- - Lukas _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel