From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <l.wagner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 7FB7B9BC2F
 for <pve-devel@lists.proxmox.com>; Tue, 21 Nov 2023 13:42:09 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 68B688F34
 for <pve-devel@lists.proxmox.com>; Tue, 21 Nov 2023 13:42:09 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Tue, 21 Nov 2023 13:42:08 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AA7C740E63
 for <pve-devel@lists.proxmox.com>; Tue, 21 Nov 2023 13:42:08 +0100 (CET)
Message-ID: <4ca4b741-1d4e-4bb3-9353-15b0ad9dfe8b@proxmox.com>
Date: Tue, 21 Nov 2023 13:42:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: de-AT, en-US
To: Philipp Hufnagl <p.hufnagl@proxmox.com>,
 Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20231121122328.134930-1-l.wagner@proxmox.com>
 <20231121122328.134930-5-l.wagner@proxmox.com>
 <6e27a91f-2a4b-4072-87ee-f097dd175a9e@proxmox.com>
From: Lukas Wagner <l.wagner@proxmox.com>
In-Reply-To: <6e27a91f-2a4b-4072-87ee-f097dd175a9e@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.009 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pve-devel] [PATCH v3 pve-manager 4/5] ui: backup: add
 'notification-mode' param for one-shot backup jobs.
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 21 Nov 2023 12:42:09 -0000



On 11/21/23 13:38, Philipp Hufnagl wrote:
>> +	let notificationModeSelector = Ext.create({
>> +	    xtype: 'proxmoxKVComboBox',
>> +	    comboItems: [
>> +		['auto', gettext('Auto')],
>> +		['legacy-sendmail', gettext('Email (legacy)')],
>> +		['notification-system', gettext('Notification system')],
>> +	    ],
>> +	    fieldLabel: gettext('Notification mode'),
>> +	    name: 'notification-mode',
>> +	    value: 'auto',
>> +	    listeners: {
>> +		change: function(field, value) {
>> +		    mailtoField.setDisabled(value === 'notification-system');
>> +		}
>> +	    }
>> +	});
>> +
> 
> nit: you missed the commas on 52 on 53

Argh, thx. Deployed/tested it via `make install` instead via
`make deb`, I think eslint is a bit more linient there.

-- 
- Lukas