From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 122C08D64C for ; Tue, 8 Nov 2022 16:28:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E6A419FE1 for ; Tue, 8 Nov 2022 16:28:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 8 Nov 2022 16:28:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3B67442B1F for ; Tue, 8 Nov 2022 16:28:54 +0100 (CET) Message-ID: <4c484143-4249-6c19-315f-93f70c9ed39f@proxmox.com> Date: Tue, 8 Nov 2022 16:28:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion , Stefan Sterz References: <20221108150130.2415229-1-s.sterz@proxmox.com> <20221108150130.2415229-2-s.sterz@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221108150130.2415229-2-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager v1 2/2] ui: add javascript source to `OnlineHelpInfo.js` prerequisites X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2022 15:28:55 -0000 Am 08/11/2022 um 16:01 schrieb Stefan Sterz: > by adding the javascript files as prerequisites, the > `OnlineHelpInfo.js` will get re-generated if a new `onlineHelp` key > is used. thus, this avoids an issue were valid keys might not get > mapped correctly because the info in `OnlineHelpInfo.js` wasn't > updated. > > Signed-off-by: Stefan Sterz > --- > i stubled accross while fixing the bug mentioned in the previous > commit. feel free to drop this, though. > > www/manager6/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks!