From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E82201FF145 for ; Thu, 05 Feb 2026 11:12:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1AB18BE7F; Thu, 5 Feb 2026 11:13:07 +0100 (CET) Message-ID: <4c042b86-b809-4575-a6d7-bedbc2ca6422@proxmox.com> Date: Thu, 5 Feb 2026 11:12:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH container 1/3] setup: add no-op check_systemd_nesting for unmanaged CTs To: pve-devel@lists.proxmox.com References: <20260204091740.102914-1-d.kral@proxmox.com> <20260204091740.102914-2-d.kral@proxmox.com> Content-Language: en-US, de-AT From: Robert Obkircher In-Reply-To: <20260204091740.102914-2-d.kral@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770286273994 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3TCM56L3HW66TFEC4HDYDBVLHSNSGSEM X-Message-ID-Hash: 3TCM56L3HW66TFEC4HDYDBVLHSNSGSEM X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/4/26 10:16, Daniel Kral wrote: > Otherwise the container will fail to start, create and clone, because > the plugin's check_systemd_nesting is only defined in the Base module > but not the Unmanaged module and is called in the pre_start_hook, > post_clone_hook, and post_create_hook. > > Reported in the Proxmox Forum [0]. > > [0] https://forum.proxmox.com/threads/180258/ > > Signed-off-by: Daniel Kral > --- > src/PVE/LXC/Setup/Unmanaged.pm | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/LXC/Setup/Unmanaged.pm b/src/PVE/LXC/Setup/Unmanaged.pm > index d76921e..aa26c1c 100644 > --- a/src/PVE/LXC/Setup/Unmanaged.pm > +++ b/src/PVE/LXC/Setup/Unmanaged.pm > @@ -51,7 +51,13 @@ sub unified_cgroupv2_support { > > sub get_ct_init_path { > my ($self) = @_; > - return '/sbin/init'; # only passed to unified_cgroupv2_support for now > + # only passed to check_systemd_nesting and unified_cgroupv2_support for now > + return '/sbin/init'; > +} > + > +sub check_systemd_nesting { > + my ($self, $conf, $init) = @_; > + return; > } Applying this patch fixed the startup problem. I tested this by changing the ostype of a Debian container to unmanaged. The only thing I've noticed is that the method is also missing from Plugin.pm. > > sub ssh_host_key_types_to_generate {