From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0DF4B618C0 for ; Mon, 7 Sep 2020 10:06:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0178B82E8 for ; Mon, 7 Sep 2020 10:06:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1886682D7 for ; Mon, 7 Sep 2020 10:06:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DEFD744A7D for ; Mon, 7 Sep 2020 10:06:02 +0200 (CEST) To: Proxmox VE development discussion , Stoiko Ivanov References: <20200903120946.23596-1-s.ivanov@proxmox.com> From: Thomas Lamprecht Message-ID: <4bf1dc8d-c7b4-25fa-2c4e-bcf2d465764d@proxmox.com> Date: Mon, 7 Sep 2020 10:06:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Thunderbird/81.0 MIME-Version: 1.0 In-Reply-To: <20200903120946.23596-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.158 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied-series: [PATCH common/manager v2] adapt PVE::Tools::sendmail to match rust-implementation and use it for apt update notifications X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Sep 2020 08:06:04 -0000 On 03.09.20 14:09, Stoiko Ivanov wrote: > v1->v2: > * dropped the moving of the email regex for reuse in the sendmail helper: > we use local usernames (mostly 'root') quite extensively in our code-base and > our users probably do so as well (for backup notifications) > * replaced the direct invocation of /usr/sbin/sendmail by a call to the helper > in pve-manager/PVE/API2/APT.pm > * adapted the sendmail-helper to allow for an empty display name in the from > header, since the apt update notification mail got sent without one. > > The second patch in pve-common can be squashed into the first one, if > preferred. The separation in two patches as you did was good and warranted. > > original cover-letter for v1: > The 2 patches adapt PVE::Tools::sendmail to closely match the recently merged > implementation in our rust repository - see [0]. > > I moved the email regex from JSONSchema to Tools to reuse it for the sendmail > function (and eliminate one of the few email-address regexes in our codebase). > > I did not add a dependency on libtimedate-perl (where Date::Format is), since > we already use Date::Parse in PVE::Certificate, without explicit dependency, > and it gets pulled in via libwww-perl -> libhttp-date-perl -> libtimedate-perl. > > Glad to send an update for the dependency of course. should still note that, depending on indirect dependency chains isn't to ideal. > > [0] https://lists.proxmox.com/pipermail/pbs-devel/2020-August/000423.html > > Stoiko Ivanov (2): > move email regex from JSONSchema to Tools > sendmail-helper: only send multipart if necessary > > src/PVE/JSONSchema.pm | 4 ++-- > src/PVE/Tools.pm | 49 +++++++++++++++++++++++++++++-------------- > 2 files changed, 35 insertions(+), 18 deletions(-) > > pve-common: > Stoiko Ivanov (2): > sendmail-helper: only send multipart if necessary > sendmail helper: allow empty display name in from > > src/PVE/Tools.pm | 43 +++++++++++++++++++++++++++++-------------- > 1 file changed, 29 insertions(+), 14 deletions(-) > > pve-manager: > Stoiko Ivanov (1): > use PVE::Tools::sendmail for update notifications > > PVE/API2/APT.pm | 19 ++++--------------- > 1 file changed, 4 insertions(+), 15 deletions(-) > applied series, thanks!