From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B9B8BB3884 for ; Wed, 29 Nov 2023 10:31:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9BCFB2F4C for ; Wed, 29 Nov 2023 10:31:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 29 Nov 2023 10:31:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D413041A39 for ; Wed, 29 Nov 2023 10:31:35 +0100 (CET) Message-ID: <4b98def2-25a9-4a59-8a5e-66095071a4d8@proxmox.com> Date: Wed, 29 Nov 2023 10:31:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Markus Frank References: <20231124123238.169891-1-m.frank@proxmox.com> From: Fiona Ebner In-Reply-To: <20231124123238.169891-1-m.frank@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.078 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [qemu-server] fix: do not allow live-migration with clipboard=vnc X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2023 09:31:36 -0000 Am 24.11.23 um 13:32 schrieb Markus Frank: > In the migrate_vm_precondition API function if clipboard > is set to vnc on a running VM the text "clipboard=vnc" > gets added to local_resources so that the GUI blocks execution and shows: > "Can't migrate VM with local resources: clipboard=vnc" > > In QemuMigrate's prepare function a new 'die' prevents a > live-migration if a running VMs has clipboard set to vnc. > > Signed-off-by: Markus Frank applied, thanks! Added the reason why to the commit message (because QEMU's vdagent device doesn't support it yet) and reworded it a bit to avoid talking about code specifics and (hopefully) improve readability. Also made a follow-up adding this information to the description of the clipboard in the schema. When it's added to the UI, it would also be great to have a hint there, because it is rather surprising that it prevents live-migration.