From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BBC7B69E2B for ; Mon, 15 Feb 2021 09:47:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE65D37AD1 for ; Mon, 15 Feb 2021 09:47:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9C01137AC1 for ; Mon, 15 Feb 2021 09:47:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6C82F44334 for ; Mon, 15 Feb 2021 09:47:06 +0100 (CET) To: pve-devel@lists.proxmox.com References: <20210212122323.15461-1-f.ebner@proxmox.com> From: Fabian Ebner Message-ID: <4b597086-dd83-ba9b-d9f8-d1a66b80e461@proxmox.com> Date: Mon, 15 Feb 2021 09:47:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210212122323.15461-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.001 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH guest-common 1/4] vzdump: loosen mailto pattern to allow whitespaces X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 08:47:07 -0000 I'm going to try and come up with a v2 that re-uses the more complete 'email' pattern from pve-common. On 12.02.21 13:23, Fabian Ebner wrote: > to make it more compatible to what we had previously. In pve-manger, > split_list() is called on the parameter, so any whitespaces and even stand-alone > ',' and ';' are taken care of, leaving only the real addresses. This also fixes > creating a backup job with empty mailto in the UI. > > For example, >> vzdump 153 --mailto " ,,,developer@proxmox.com; admin@proxmox.com ; " > was valid and worked in PVE 6.2. > > Signed-off-by: Fabian Ebner > --- > PVE/VZDump/Common.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm > index af141de..fb11b3d 100644 > --- a/PVE/VZDump/Common.pm > +++ b/PVE/VZDump/Common.pm > @@ -72,7 +72,7 @@ sub parse_dow { > }; > > my $mailto_pattern = '[a-zA-Z0-9+._@][-a-zA-Z0-9+._@]*'; > -my $mailto_list_pattern = "($mailto_pattern)([;,]$mailto_pattern)*"; > +my $mailto_list_pattern = qr/([;,]?(?:$mailto_pattern|\s*))*/; > > my $confdesc = { > vmid => { >