From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1E5C49F8C8 for ; Tue, 7 Nov 2023 08:51:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EFBA91E6D2 for ; Tue, 7 Nov 2023 08:50:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 7 Nov 2023 08:50:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3E86E46E2E; Tue, 7 Nov 2023 08:50:45 +0100 (CET) Message-ID: <4b221820-548b-48d8-a2ba-5ba7bd26435f@proxmox.com> Date: Tue, 7 Nov 2023 08:50:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Content-Language: en-US To: Thomas Lamprecht , Proxmox VE development discussion References: <20230615080815.921858-1-d.csapak@proxmox.com> From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2023 07:51:16 -0000 On 11/6/23 17:31, Thomas Lamprecht wrote: > Am 15/06/2023 um 10:08 schrieb Dominik Csapak: >> this field has a fixed height, which is too tall for the create wizard, >> and one cannot see the last entry when scrolling all the way down. >> >> to fix this, make it 20px shorter > > was still broken in the german translation, as that takes up more space in > a label higher up in the panel. > >> >> Signed-off-by: Dominik Csapak >> --- >> alternatively we could also increase the height in the create wizard > > I went for that route for now, increasing that from 510 to 540 (4:3 ratio > to width). > ok >> the optimal solution would be to improve the layouting in our >> wizard/inputpanel altogether so that it automatically gets the right >> height, but that is a non-trivial rework there. imho this should work >> fine as a stopgap fix for now > > just out of interest, could setting a flex+maxHeight for the extra-flags > also have been an option? AFAICS there is no way to do that. The columns in an inputpanel are an 'anchor' layout, and I could not set it so that it would take the remaining height of the panel. But theoretically yes, if we could make it 'flex' height + a maxHeight for the non wizard case this would also work. (possibly with my mentioned rework of the input panel layout)