From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id BD0CA1FF0B3 for ; Wed, 11 Nov 2026 14:28:38 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C1010216A5; Wed, 11 Nov 2026 14:28:36 +0100 (CET) Message-ID: <4afe75a7-48ce-4812-b202-195bc71387b3@proxmox.com> Date: Wed, 11 Nov 2026 14:28:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH pve-manager v2 0/2] ui: vm create: populate EFI and To: pve-devel@lists.proxmox.com References: <20260806130152.207884-1-j.theisen@proxmox.com> Content-Language: en-US From: Jonas Theisen In-Reply-To: <20260806130152.207884-1-j.theisen@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794403711966 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.094 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3Z7LYNXANPTWIOTNW4KGNHNERM3AIGNY X-Message-ID-Hash: 3Z7LYNXANPTWIOTNW4KGNHNERM3AIGNY X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/6/26 15:01, Jonas Theisen wrote: > On VM creation the storage dropdown for EFI and TPM were empty, > while the storage for VM disks was populated by default. > > This patch series adds the parameters to the selectors to also > populate the storage for EFI and TPM disks automatically and fixes > an issue where disabling and reenabling the selectors would not > trigger the autofill. > > Reported by a forum user in https://forum.proxmox.com/threads/185473/ > > Signed-off-by: Jonas Theisen > > Jonas Theisen (2): > ui: vm create: populate EFI and TPM storage by default > ui: vm: create: fix autoSelect for disk storage selector when > re-enabling field > > www/manager6/form/DiskStorageSelector.js | 5 +++++ > www/manager6/qemu/HDEfi.js | 1 + > www/manager6/qemu/HDTPM.js | 1 + > www/manager6/qemu/SystemEdit.js | 2 ++ > 4 files changed, 9 insertions(+) > Gentle ping One review by @e.huhsovitz already in, thanks!