From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E60CB75DA0 for ; Fri, 15 Oct 2021 19:59:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E3F77BC4E for ; Fri, 15 Oct 2021 19:59:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C8B69BC3E for ; Fri, 15 Oct 2021 19:59:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9EA62466AC for ; Fri, 15 Oct 2021 19:59:45 +0200 (CEST) Message-ID: <4aaa2439-8aa7-25e5-9a9c-384c96b7ce16@proxmox.com> Date: Fri, 15 Oct 2021 19:59:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20211007134531.1693674-1-d.csapak@proxmox.com> <20211007134531.1693674-4-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211007134531.1693674-4-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.203 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] applied: [PATCH qemu-server v3 3/3] fix #3258: block vm start when pci device is already in use X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Oct 2021 17:59:46 -0000 On 07.10.21 15:45, Dominik Csapak wrote: > on vm start, we reserve all pciids that we use, and > remove the reservation again in vm_stop_cleanup > > first with only a time-based reservation but after the vm is started, > we reserve again but with the pid. > > for this, we have to move the start_timeout calculation above the > hostpci handling. > > also moved the pci initialization out of the conf parsing loop > so that we can reserve all ids before we actually touch any of them > > while touching the lines, fix the indentation > > this way, when a vm starts with a pci device that is already configured > for a different running vm, will not be started and the user gets > the error that the device is already in use > > Signed-off-by: Dominik Csapak > --- > PVE/QemuServer.pm | 50 +++++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 42 insertions(+), 8 deletions(-) > > applied but had to resolve a merge conflict which, thanks!