From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6CCAE71A05 for ; Tue, 5 Oct 2021 06:19:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5CED622FD2 for ; Tue, 5 Oct 2021 06:18:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3A04622FC2 for ; Tue, 5 Oct 2021 06:18:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 16B8B45568 for ; Tue, 5 Oct 2021 06:18:47 +0200 (CEST) Message-ID: <4a0a0805-4450-f0ed-464c-fb022ad7b062@proxmox.com> Date: Tue, 5 Oct 2021 06:17:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Thunderbird/93.0 Content-Language: en-US To: Proxmox VE development discussion , Oguz Bektas References: <20211004145513.2141283-1-o.bektas@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211004145513.2141283-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.227 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [unmanaged.pm, setup.pm] Subject: Re: [pve-devel] [PATCH container] fix creating unmanaged containers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 04:19:18 -0000 On 04.10.21 16:55, Oguz Bektas wrote: > $keynames was not a hash reference since nothing was returned by > ssh_host_key_types_to_generate for unmanaged containers, this causes the > post_create_hook to fail and no container is created. While $keynames is not a hash ref it isn't supposed to always be one, that's why the check is: return if !$keynames || !scalar(keys $keynames->%*); so this patch seems wrong? At least in regards on the fix's reasoning > > fix by returning an empty hash so that $keynames can be a hashref and > processed accordingly. > > also dropped a remaining unmanaged return (should have no effect anymore > anyways, since $self->{plugin} is now set to 'unmanaged' instead of > empty) good catch, but should be another, separate patch.. > > --- > > note that we can still allow generating ssh keys for unmanaged > containers, i have another patch like that (i can send if you wish), > which doesn't skip creating ssh keys -- however for that to work we need > to use functions from PVE::Tools (so that we can have ct_file_exists and > friends) > > src/PVE/LXC/Setup.pm | 2 -- > src/PVE/LXC/Setup/Unmanaged.pm | 1 + > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm > index cfbe02c..4e211ef 100644 > --- a/src/PVE/LXC/Setup.pm > +++ b/src/PVE/LXC/Setup.pm > @@ -228,8 +228,6 @@ my sub generate_ssh_key { # create temporary key in hosts' /run, then read and u > sub rewrite_ssh_host_keys { > my ($self) = @_; > > - return if !$self->{plugin}; # unmanaged > - > my $plugin = $self->{plugin}; > > my $keynames = $plugin->ssh_host_key_types_to_generate(); > diff --git a/src/PVE/LXC/Setup/Unmanaged.pm b/src/PVE/LXC/Setup/Unmanaged.pm > index 38e245f..2ca2898 100644 > --- a/src/PVE/LXC/Setup/Unmanaged.pm > +++ b/src/PVE/LXC/Setup/Unmanaged.pm > @@ -51,6 +51,7 @@ sub unified_cgroupv2_support { > > sub ssh_host_key_types_to_generate { > my ($self) = @_; > + return {}; > } > > # hooks >