From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 75CBE6E654 for ; Tue, 24 Aug 2021 11:07:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5E8ED2B642 for ; Tue, 24 Aug 2021 11:06:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5F71C2B632 for ; Tue, 24 Aug 2021 11:06:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1B7A14079A; Tue, 24 Aug 2021 11:06:48 +0200 (CEST) Message-ID: <49b6244d-b23a-f201-2f52-500fd10fa1c2@proxmox.com> Date: Tue, 24 Aug 2021 11:06:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-GB To: Proxmox VE development discussion , Alexandre Derumier References: <20210805145900.3265228-1-aderumier@odiso.com> <20210805145900.3265228-3-aderumier@odiso.com> From: Thomas Lamprecht In-Reply-To: <20210805145900.3265228-3-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.378 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.023 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-manager 1/2] permpathstore: add sdn zones X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Aug 2021 09:07:19 -0000 On 05/08/2021 16:58, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > www/manager6/data/PermPathStore.js | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/www/manager6/data/PermPathStore.js b/www/manager6/data/PermPathStore.js > index 1dc276b6..cf702c03 100644 > --- a/www/manager6/data/PermPathStore.js > +++ b/www/manager6/data/PermPathStore.js > @@ -10,6 +10,7 @@ Ext.define('PVE.data.PermPathStore', { > { 'value': '/access/realm' }, > { 'value': '/nodes' }, > { 'value': '/pool' }, > + { 'value': '/sdn/zones' }, Would need guarding similar to how we hide other SDN stuff for now, else it could be confusing to some. I.e., adding something like the following stanza in the constructor between the suspendEvents and resumeEvents calls: if (PVE.SDNInfo) { me.add({ value: '/sdn/zones' }); } > { 'value': '/storage' }, > { 'value': '/vms' }, > ], > @@ -32,6 +33,8 @@ Ext.define('PVE.data.PermPathStore', { > break; > case 'lxc': path = '/vms/' + record.get('vmid'); > break; > + case 'sdn': path = '/sdn/zones/' + record.get('sdn'); > + break; > case 'storage': path = '/storage/' + record.get('storage'); > break; > case 'pool': path = '/pool/' + record.get('pool'); >