From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6CFA176B0E for ; Fri, 16 Jul 2021 17:59:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D16013512 for ; Fri, 16 Jul 2021 17:59:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D2B5613502 for ; Fri, 16 Jul 2021 17:59:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AC52C42165 for ; Fri, 16 Jul 2021 17:59:38 +0200 (CEST) Message-ID: <4998e52e-c99d-1ced-21dd-c40708ff14e2@proxmox.com> Date: Fri, 16 Jul 2021 17:59:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-US To: Proxmox VE development discussion , Stoiko Ivanov References: <20210716134305.3729415-1-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210716134305.3729415-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.383 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [acme.sh] Subject: [pve-devel] applied: [PATCH proxmox-acme] plugin-caller: make no-ops always successful X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jul 2021 15:59:40 -0000 On 16.07.21 15:43, Stoiko Ivanov wrote: > proxmox-acme is used to call the dns-plugins from acme.sh and has the > config editing (saving/clearing) turned int no-ops. > > bash's `return` statement w/o argument returns the value of the last > executed command (the one before our no-op method was called) (see > `help return` in bash). > This leads to unexpected behavior in some plugins, which call one of > the methods as last statement join the next step with `&&`. > > tested bash behavior with: > ``` > foo() { return; }; if [ -z 'x' ]; then :; else foo ; fi; echo $? > ``` > > reported in our community-forum: > https://forum.proxmox.com/threads/pmg-acme-dns-with-cyon-failing-to-issue-certificate.92762 > > Signed-off-by: Stoiko Ivanov > --- > src/proxmox-acme | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > applied, thanks!