From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 528F5601A1 for ; Fri, 4 Feb 2022 17:38:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4BF0A2C9 for ; Fri, 4 Feb 2022 17:38:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B9AC32BD for ; Fri, 4 Feb 2022 17:38:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8F86D44FB2 for ; Fri, 4 Feb 2022 17:38:26 +0100 (CET) Message-ID: <4956f028-8059-28cc-388b-97753b6bf681@proxmox.com> Date: Fri, 4 Feb 2022 17:38:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20220113110405.67232-1-f.ebner@proxmox.com> <20220113110405.67232-3-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220113110405.67232-3-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [abstractconfig.pm] Subject: [pve-devel] applied: [PATCH v2 guest-common 2/2] config: activate affected storages for snapshot operations X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 16:38:27 -0000 On 13.01.22 12:04, Fabian Ebner wrote: > For snapshot creation, the storage for the vmstate file is activated > via vdisk_alloc when the state file is created. > > Do not activate the volumes themselves, as that has unnecessary side > effects (e.g. waiting for zvol device link for ZFS, mapping the volume > for RBD). If a storage can only do snapshot operations on a volume > that has been activated, it needs to activate the volume itself. > > The actual implementation will be in the plugins to be able to skip > CD ROM drives and bind-mounts, etc. > > Signed-off-by: Fabian Ebner > --- > src/PVE/AbstractConfig.pm | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > applied, thanks! But I defused the fixme comment, this is internal and doesn't need to wait until a major release.