From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AFAA61FF145 for ; Thu, 22 Jan 2026 16:59:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F1BAF1B4B5; Thu, 22 Jan 2026 16:59:48 +0100 (CET) Message-ID: <4932781e-ffaa-4ab9-b99d-804d2c9ca140@proxmox.com> Date: Thu, 22 Jan 2026 16:59:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Dominik Csapak References: <20260122140143.2256222-1-d.csapak@proxmox.com> <20260122140143.2256222-3-d.csapak@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260122140143.2256222-3-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769097526881 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager 2/4] ui: pool create: allow selecting parent pool via selector X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 22.01.26 um 15:01 schrieb Dominik Csapak: > instead of having to type out the full path, e.g. 'foo/bar/baz', > show a 'pool selector' to select the parent pool. > > This makes creating nested pools more obvious and easier. > > Signed-off-by: Dominik Csapak > --- > www/manager6/dc/PoolEdit.js | 48 +++++++++++++++++++++++++++---------- > 1 file changed, 35 insertions(+), 13 deletions(-) > > diff --git a/www/manager6/dc/PoolEdit.js b/www/manager6/dc/PoolEdit.js > index 72a084ac..325f649b 100644 > --- a/www/manager6/dc/PoolEdit.js > +++ b/www/manager6/dc/PoolEdit.js > @@ -17,20 +17,42 @@ Ext.define('PVE.dc.PoolEdit', { > > items: [ > { > - xtype: 'pmxDisplayEditField', > - fieldLabel: gettext('Name'), > - cbind: { > - editable: '{isCreate}', > - value: '{poolid}', > + xtype: 'inputpanel', > + onGetValues: function (values) { > + if (values.parentPool) { > + values.poolid = values.parentPool + '/' + values.poolid; > + delete values.parentPool; > + } If values.parentPool is an empty string it will evaluate to falsy above, but then still exist and gets submitted, so with this patch one cannot create any top-level pool anymore. Something else, one can mix-and match parent field and using / separators in the name, seems a bit odd and potentially confusing UX wise. Maybe it would be better to just disallow using / in the name then, having that would be only useful if we would also created all intermediate pools, which we currently don't. > + return values; > }, > - name: 'poolid', > - allowBlank: false, > - }, > - { > - xtype: 'textfield', > - fieldLabel: gettext('Comment'), > - name: 'comment', > - allowBlank: true, > + items: [ > + { > + xtype: 'pmxDisplayEditField', > + fieldLabel: gettext('Name'), > + cbind: { > + editable: '{isCreate}', > + value: '{poolid}', > + }, > + name: 'poolid', > + allowBlank: false, > + }, > + { > + xtype: 'pvePoolSelector', > + name: 'parentPool', > + fieldLabel: gettext('Parent Pool'), > + allowBlank: true, > + cbind: { > + disabled: '{!isCreate}', > + hidden: '{!isCreate}', > + }, > + }, > + { > + xtype: 'textfield', > + fieldLabel: gettext('Comment'), > + name: 'comment', > + allowBlank: true, > + }, > + ], > }, > ], > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel