From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1D09874EE9 for ; Wed, 23 Jun 2021 10:14:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 93BDE2F838 for ; Wed, 23 Jun 2021 10:13:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2355E2F82A for ; Wed, 23 Jun 2021 10:13:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E936D425B9 for ; Wed, 23 Jun 2021 10:13:56 +0200 (CEST) Message-ID: <488840ae-f73a-5436-6bfe-a455010bc2fc@proxmox.com> Date: Wed, 23 Jun 2021 10:13:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20210623074532.12141-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210623074532.12141-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.676 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH spiceterm] screen.c: fix exiting on client disconnect X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2021 08:14:29 -0000 On 23.06.21 09:45, Dominik Csapak wrote: > the way we detected a client_disconnect does not work anymore with > spice-server >= 0.14.3, but there is a convienient function > that exits the spice-server on client disconnect > > there is a slight behaviour change that should not make a big difference: > > previously, if a user used the same '.vv' file twice, the first client > got disconnected and the second would connect > > now, because the server closes on disconnect, the second client is > not be able to connect anymore > > using our ui though, every click on 'shell>spice' generates a new '.vv' > file that works though (and for container shells we use dtach to mux) > > i could not (in reasonable time) find out why the first client > disconnects at all, and also could not find another way to detect a > client disconnect that is similar to our previous method > > Signed-off-by: Dominik Csapak > --- > src/screen.c | 2 ++ > 1 file changed, 2 insertions(+) > > applied, thanks!