From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4ECCA9E38D for ; Tue, 6 Jun 2023 17:23:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2C4B63813F for ; Tue, 6 Jun 2023 17:23:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 6 Jun 2023 17:23:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1A93948CFC for ; Tue, 6 Jun 2023 17:23:30 +0200 (CEST) Message-ID: <47e917a8-6b93-3590-1313-715dd3b0a7fe@proxmox.com> Date: Tue, 6 Jun 2023 17:23:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB, de-AT To: Proxmox VE development discussion , Fiona Ebner References: <20230315132425.119055-1-f.ebner@proxmox.com> From: Thomas Lamprecht Autocrypt: addr=t.lamprecht@proxmox.com; keydata= xsFNBFsLjcYBEACsaQP6uTtw/xHTUCKF4VD4/Wfg7gGn47+OfCKJQAD+Oyb3HSBkjclopC5J uXsB1vVOfqVYE6PO8FlD2L5nxgT3SWkc6Ka634G/yGDU3ZC3C/7NcDVKhSBI5E0ww4Qj8s9w OQRloemb5LOBkJNEUshkWRTHHOmk6QqFB/qBPW2COpAx6oyxVUvBCgm/1S0dAZ9gfkvpqFSD 90B5j3bL6i9FIv3YGUCgz6Ue3f7u+HsEAew6TMtlt90XV3vT4M2IOuECG/pXwTy7NtmHaBQ7 UJBcwSOpDEweNob50+9B4KbnVn1ydx+K6UnEcGDvUWBkREccvuExvupYYYQ5dIhRFf3fkS4+ wMlyAFh8PQUgauod+vqs45FJaSgTqIALSBsEHKEs6IoTXtnnpbhu3p6XBin4hunwoBFiyYt6 YHLAM1yLfCyX510DFzX/Ze2hLqatqzY5Wa7NIXqYYelz7tXiuCLHP84+sV6JtEkeSUCuOiUY virj6nT/nJK8m0BzdR6FgGtNxp7RVXFRz/+mwijJVLpFsyG1i0Hmv2zTn3h2nyGK/I6yhFNt dX69y5hbo6LAsRjLUvZeHXpTU4TrpN/WiCjJblbj5um5eEr4yhcwhVmG102puTtuCECsDucZ jpKpUqzXlpLbzG/dp9dXFH3MivvfuaHrg3MtjXY1i+/Oxyp5iwARAQABzTNUaG9tYXMgTGFt cHJlY2h0IChBdXRoLTQpIDx0LmxhbXByZWNodEBwcm94bW94LmNvbT7CwY4EEwEIADgWIQQO R4qbEl/pah9K6VrTZCM6gDZWBgUCWwuNxgIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAK CRDTZCM6gDZWBm/jD/4+6JB2s67eaqoP6x9VGaXNGJPCscwzLuxDTCG90G9FYu29VcXtubH/ bPwsyBbNUQpqTm/s4XboU2qpS5ykCuTjqavrcP33tdkYfGcItj2xMipJ1i3TWvpikQVsX42R G64wovLs/dvpTYphRZkg5DwhgTmy3mRkmofFCTa+//MOcNOORltemp984tWjpR3bUJETNWpF sKGZHa3N4kCNxb7A+VMsJZ/1gN3jbQbQG7GkJtnHlWkw9rKCYqBtWrnrHa4UAvSa9M/XCIAB FThFGqZI1ojdVlv5gd6b/nWxfOPrLlSxbUo5FZ1i/ycj7/24nznW1V4ykG9iUld4uYUY86bB UGSjew1KYp9FmvKiwEoB+zxNnuEQfS7/Bj1X9nxizgweiHIyFsRqgogTvLh403QMSGNSoArk tqkorf1U+VhEncIn4H3KksJF0njZKfilrieOO7Vuot1xKr9QnYrZzJ7m7ZxJ/JfKGaRHXkE1 feMmrvZD1AtdUATZkoeQtTOpMu4r6IQRfSdwm/CkppZXfDe50DJxAMDWwfK2rr2bVkNg/yZI tKLBS0YgRTIynkvv0h8d9dIjiicw3RMeYXyqOnSWVva2r+tl+JBaenr8YTQw0zARrhC0mttu cIZGnVEvQuDwib57QLqMjQaC1gazKHvhA15H5MNxUhwm229UmdH3KM7BTQRbC43GARAAyTkR D6KRJ9Xa2fVMh+6f186q0M3ni+5tsaVhUiykxjsPgkuWXWW9MbLpYXkzX6h/RIEKlo2BGA95 QwG5+Ya2Bo3g7FGJHAkXY6loq7DgMp5/TVQ8phsSv3WxPTJLCBq6vNBamp5hda4cfXFUymsy HsJy4dtgkrPQ/bnsdFDCRUuhJHopnAzKHN8APXpKU6xV5e3GE4LwFsDhNHfH/m9+2yO/trcD txSFpyftbK2gaMERHgA8SKkzRhiwRTt9w5idOfpJVkYRsgvuSGZ0pcD4kLCOIFrer5xXudk6 NgJc36XkFRMnwqrL/bB4k6Pi2u5leyqcXSLyBgeHsZJxg6Lcr2LZ35+8RQGPOw9C0ItmRjtY ZpGKPlSxjxA1WHT2YlF9CEt3nx7c4C3thHHtqBra6BGPyW8rvtq4zRqZRLPmZ0kt/kiMPhTM 8wZAlObbATVrUMcZ/uNjRv2vU9O5aTAD9E5r1B0dlqKgxyoImUWB0JgpILADaT3VybDd3C8X s6Jt8MytUP+1cEWt9VKo4vY4Jh5vwrJUDLJvzpN+TsYCZPNVj18+jf9uGRaoK6W++DdMAr5l gQiwsNgf9372dbMI7pt2gnT5/YdG+ZHnIIlXC6OUonA1Ro/Itg90Q7iQySnKKkqqnWVc+qO9 GJbzcGykxD6EQtCSlurt3/5IXTA7t6sAEQEAAcLBdgQYAQgAIBYhBA5HipsSX+lqH0rpWtNk IzqANlYGBQJbC43GAhsMAAoJENNkIzqANlYGD1sP/ikKgHgcspEKqDED9gQrTBvipH85si0j /Jwu/tBtnYjLgKLh2cjv1JkgYYjb3DyZa1pLsIv6rGnPX9bH9IN03nqirC/Q1Y1lnbNTynPk IflgvsJjoTNZjgu1wUdQlBgL/JhUp1sIYID11jZphgzfDgp/E6ve/8xE2HMAnf4zAfJaKgD0 F+fL1DlcdYUditAiYEuN40Ns/abKs8I1MYx7Yglu3RzJfBzV4t86DAR+OvuF9v188WrFwXCS RSf4DmJ8tntyNej+DVGUnmKHupLQJO7uqCKB/1HLlMKc5G3GLoGqJliHjUHUAXNzinlpE2Vj C78pxpwxRNg2ilE3AhPoAXrY5qED5PLE9sLnmQ9AzRcMMJUXjTNEDxEYbF55SdGBHHOAcZtA kEQKub86e+GHA+Z8oXQSGeSGOkqHi7zfgW1UexddTvaRwE6AyZ6FxTApm8wq8NT2cryWPWTF BDSGB3ujWHMM8ERRYJPcBSjTvt0GcEqnd+OSGgxTkGOdufn51oz82zfpVo1t+J/FNz6MRMcg 8nEC+uKvgzH1nujxJ5pRCBOquFZaGn/p71Yr0oVitkttLKblFsqwa+10Lt6HBxm+2+VLp4Ja 0WZNncZciz3V3cuArpan/ZhhyiWYV5FD0pOXPCJIx7WS9PTtxiv0AOS4ScWEUmBxyhFeOpYa DrEx In-Reply-To: <20230315132425.119055-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager] close #4513: ui: backup job: add performance tab X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2023 15:23:31 -0000 stumbled upon this again when checking out old(er) patches without comments, some higher level comments inline. Am 15/03/2023 um 14:24 schrieb Fiona Ebner: > pigz is not exposed, because it only works after manually installing > the pigz package. > > ionice is not exposed, because it only works in combination with the > BFQ scheduler and even then not in all cases (only affects the > compressor when doing snapshot/suspend mode backup of a VM). > > These can still be added with appropriate notes if there is enough > user demand. > > Signed-off-by: Fiona Ebner > --- > www/manager6/Makefile | 1 + > www/manager6/dc/Backup.js | 12 +++ > www/manager6/panel/BackupPerformance.js | 110 ++++++++++++++++++++++++ > 3 files changed, 123 insertions(+) > create mode 100644 www/manager6/panel/BackupPerformance.js > > diff --git a/www/manager6/Makefile b/www/manager6/Makefile > index b73b729a..0c92b984 100644 > --- a/www/manager6/Makefile > +++ b/www/manager6/Makefile > @@ -88,6 +88,7 @@ JSSRC= \ > grid/ResourceGrid.js \ > panel/ConfigPanel.js \ > panel/BackupJobPrune.js \ > + panel/BackupPerformance.js \ > panel/HealthWidget.js \ > panel/IPSet.js \ > panel/RunningChart.js \ > diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js > index d0046177..8da6e7d7 100644 > --- a/www/manager6/dc/Backup.js > +++ b/www/manager6/dc/Backup.js > @@ -172,6 +172,11 @@ Ext.define('PVE.dc.BackupEdit', { > PVE.Utils.unEscapeNotesTemplate(data['notes-template']); > } > > + if (data.performance) { > + Object.assign(data, data.performance); > + delete data.performance; > + } > + > view.setValues(data); > }, > }); > @@ -411,6 +416,13 @@ Ext.define('PVE.dc.BackupEdit', { > }, > ], > }, > + { > + xtype: 'pveBackupPerformancePanel', > + title: gettext('Performance'), > + cbind: { > + isCreate: '{isCreate}', > + }, > + }, > ], > }, > ], > diff --git a/www/manager6/panel/BackupPerformance.js b/www/manager6/panel/BackupPerformance.js > new file mode 100644 > index 00000000..17e0f34c > --- /dev/null > +++ b/www/manager6/panel/BackupPerformance.js > @@ -0,0 +1,110 @@ > +/* > + * Input panel for backup performance settings intended to be used as part of an edit/create window. > + */ > +Ext.define('PVE.panel.BackupPerformance', { > + extend: 'Proxmox.panel.InputPanel', > + xtype: 'pveBackupPerformancePanel', > + mixins: ['Proxmox.Mixin.CBind'], > + > + cbindData: function() { > + let me = this; > + me.isCreate = !!me.isCreate; > + return {}; > + }, > + > + onGetValues: function(formValues) { > + if (this.needMask) { // isMasked() may not yet be true if not rendered once > + return {}; > + } > + > + let options = { 'delete': [] }; > + > + let performance = {}; > + let performanceOptions = ['max-workers']; > + > + for (const [key, value] of Object.entries(formValues)) { > + if (performanceOptions.includes(key)) { > + performance[key] = value; > + // deleteEmpty is not currently implemented for pveBandwidthField > + } else if (key === 'bwlimit' && value === '') { > + options.delete.push('bwlimit'); > + } else if (key === 'delete') { > + if (Array.isArray(value)) { > + value.filter(opt => !performanceOptions.includes(opt)).forEach( > + opt => options.delete.push(opt), > + ); > + } else if (!performanceOptions.includes(formValues.delete)) { > + options.delete.push(value); > + } > + } else { > + options[key] = value; > + } > + } > + > + if (Object.keys(performance).length > 0) { > + options.performance = PVE.Parser.printPropertyString(performance); > + } else { > + options.delete.push('performance'); > + } > + > + if (this.isCreate) { > + delete options.delete; > + } > + > + return options; > + }, > + hmm, maybe we should go for a layout with one field per row, but besides that a short description about what it controls, like: Label [ Field ] Description Where the descriptions are sorta in the style of the CPU flag ones for VM CPU edit, i.e., provide some context and hint of what this does. Because max-workers "VM Worker Count" is not easily understandable IMO, i.e., one could think that's parallel backups done by separate workers (like e.g., max worker is used for migrate-all or HA LRM parallel workers) > + column1: [ > + { > + xtype: 'proxmoxintegerfield', > + name: 'zstd', > + fieldLabel: Ext.String.format('{0} ({1})', gettext('Thread count'), 'zstd'), > + emptyText: gettext('use fallback'), disabling that when ZSTD is not selected might slightly improve UX too. > + minValue: 0, > + cbind: { > + deleteEmpty: '{!isCreate}', > + }, > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext('With 0, half of the available cores are used'), > + }, > + }, > + { > + xtype: 'proxmoxintegerfield', > + name: 'max-workers', > + minValue: 1, > + maxValue: 256, > + fieldLabel: Ext.String.format('{0} ({1})', gettext('Worker count'), 'VM'), > + emptyText: gettext('use fallback'), > + cbind: { > + deleteEmpty: '{!isCreate}', > + }, > + }, > + ], > + > + column2: [ > + { > + xtype: 'pveBandwidthField', > + name: 'bwlimit', > + fieldLabel: gettext('Bandwidth Limit'), > + emptyText: gettext('use fallback'), > + backendUnit: 'KiB', > + allowZero: true, > + emptyValue: '', > + autoEl: { > + tag: 'div', > + 'data-qtip': Ext.String.format(gettext('Use {0} for unlimited'), 0), > + }, > + }, > + ], > + > + columnB: [ > + { > + xtype: 'component', > + userCls: 'pmx-hint', > + name: 'pbs-hint', > + padding: '5 1', > + html: gettext("Note that vzdump.conf is used as a fallback"), > + }, > + ], > +});