From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <l.wagner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id A9B958BBF
 for <pve-devel@lists.proxmox.com>; Fri,  1 Sep 2023 08:55:09 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 93121121B5
 for <pve-devel@lists.proxmox.com>; Fri,  1 Sep 2023 08:55:09 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Fri,  1 Sep 2023 08:55:07 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 742FB47CCF
 for <pve-devel@lists.proxmox.com>; Fri,  1 Sep 2023 08:55:07 +0200 (CEST)
Message-ID: <477e5db9-3235-4d97-9fd5-4ec0e9ccdb17@proxmox.com>
Date: Fri, 1 Sep 2023 08:55:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: pve-devel@lists.proxmox.com
References: <20230718095305.227893-1-l.wagner@proxmox.com>
Content-Language: de-AT, en-US
From: Lukas Wagner <l.wagner@proxmox.com>
In-Reply-To: <20230718095305.227893-1-l.wagner@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.033 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager] ui: replication: backup: use
 renderEnabledIcon to render the enabled column
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 01 Sep 2023 06:55:09 -0000

Ping

On 7/18/23 11:53, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>   www/manager6/dc/Backup.js        | 3 +--
>   www/manager6/grid/Replication.js | 3 +--
>   2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
> index 03a02651..e662dd36 100644
> --- a/www/manager6/dc/Backup.js
> +++ b/www/manager6/dc/Backup.js
> @@ -722,8 +722,7 @@ Ext.define('PVE.dc.BackupView', {
>   		    width: 80,
>   		    dataIndex: 'enabled',
>   		    align: 'center',
> -		    // TODO: switch to Proxmox.Utils.renderEnabledIcon once available
> -		    renderer: enabled => `<i class="fa fa-${enabled ? 'check' : 'minus'}"></i>`,
> +		    renderer: Proxmox.Utils.renderEnabledIcon,
>   		    sortable: true,
>   		},
>   		{
> diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js
> index 30cd6718..1e4e00fc 100644
> --- a/www/manager6/grid/Replication.js
> +++ b/www/manager6/grid/Replication.js
> @@ -283,8 +283,7 @@ Ext.define('PVE.grid.ReplicaView', {
>   		width: 80,
>   		dataIndex: 'enabled',
>   		align: 'center',
> -		// TODO: switch to Proxmox.Utils.renderEnabledIcon once available
> -		renderer: enabled => `<i class="fa fa-${enabled ? 'check' : 'minus'}"></i>`,
> +		renderer: Proxmox.Utils.renderEnabledIcon,
>   		sortable: true,
>   	    },
>   	    {

-- 
- Lukas