From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B1EA369A14 for ; Wed, 24 Feb 2021 19:56:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A89702D435 for ; Wed, 24 Feb 2021 19:56:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3987C2D428 for ; Wed, 24 Feb 2021 19:56:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EFA2946308 for ; Wed, 24 Feb 2021 19:56:09 +0100 (CET) Message-ID: <4725e9dc-cf09-4e80-3018-0f392e4f9957@proxmox.com> Date: Wed, 24 Feb 2021 19:56:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Thunderbird/86.0 Content-Language: en-US To: Proxmox VE development discussion , Stefan Reiter References: <20210224133447.14692-1-s.reiter@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210224133447.14692-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.056 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH pve-qemu] pbs-restore: unref/close target block backend X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2021 18:56:10 -0000 On 24.02.21 14:34, Stefan Reiter wrote: > Use blk_unref to drop the last reference, which will close the block > backend and flush all caches and outstanding writes. > > This is especially important for restoring to Ceph, as the userspace > librbd caches will not be flushed if the application exits immediately, > leading to potentially incomplete restores. > > Reported-by: Eneko Lacunza > Signed-off-by: Stefan Reiter > --- > > I was now able to reproduce the issue on Ceph, and this successfully fixes it > for me. Hash sums of before and after the restore now match up. > > Without this, the difference in restored images would manifest in the broken one > simply missing some data at the back, instead just having zeroes there. This > might also be why it's not too noticeable usually - most data would be stored in > the earlier parts of the image, which always had enough time to be flushed. > > This also brings it more in line with the code in vma.c, though we do a > bdrv_close_all there too - I did not find that to be necessary here, as > blk_unref already closes all attached block driver instances. > > ...ackup-pbs-restore-new-command-to-restore-from-p.patch | 9 +++++---- > debian/patches/pve/0039-PVE-fixup-pbs-restore-API.patch | 2 +- > 2 files changed, 6 insertions(+), 5 deletions(-) > > applied, thanks!