From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 3B5031FF15E
	for <inbox@lore.proxmox.com>; Tue,  8 Apr 2025 09:01:45 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id C01BFBF8D;
	Tue,  8 Apr 2025 09:01:40 +0200 (CEST)
Message-ID: <46ea2449-c2a2-49bd-8215-b4603c5cb87f@proxmox.com>
Date: Tue, 8 Apr 2025 09:01:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
 Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20250407101310.3196974-1-d.csapak@proxmox.com>
 <20250407101310.3196974-6-d.csapak@proxmox.com>
 <1b3cd284-9345-4fcd-ad3a-e7ac874f7548@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <1b3cd284-9345-4fcd-ad3a-e7ac874f7548@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.022 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager v6 3/4] ui: qemu hd edit: allow
 importing a disk from the import storage
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On 4/8/25 00:13, Thomas Lamprecht wrote:
> Am 07.04.25 um 12:13 schrieb Dominik Csapak:
>> adds a checkbox 'import image' above the storage selector which:
>> * hides the original storage selector
>> * shows a 'source storage' selector
>> * shows a 'import file' selector
>> * shows a 'target storage' selector
>>
>> Since the wizard and the hd edit share this panel, this also works in
>> the wizard.
> 
> Can we disable this for HD Add? IMO that dialogue is already really
> complex as is.
> 
> Might be even beneficial if this is always predefined from the call
> or integration side...
> 
> And seems I cannot start an import through the import storage content
> view? Feels odd to me, all other imports are triggered there after all.

ok so if I understand you correctly, you want this in the wizard but not
in the 'add hd' panel ? And you want to have a (probably simplified) hd
add panel from the import storage content panel directly ?

sounds fine to me, an alternative I could offer would be to
have a separate input panel only for importing, and show in the wizard
another button (e.g. split button on add) that adds that import panel
and for the guests a new entry in the 'add menu' that says 'import'

(this panel could then also be added to the import storage content,
with an additional vm selector)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel