From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9FE9A1FF56B for ; Mon, 22 Apr 2024 14:13:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 70D2D10390; Mon, 22 Apr 2024 14:13:18 +0200 (CEST) Message-ID: <46ba4aee-093e-4024-ae15-6e21c2d1a4ca@proxmox.com> Date: Mon, 22 Apr 2024 14:12:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Alexander Zeidler References: <20240419163345.263086-1-a.zeidler@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240419163345.263086-1-a.zeidler@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.067 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 manager] pve7to8: reword and fix typos in description X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 19.04.24 um 18:33 schrieb Alexander Zeidler: > diff --git a/bin/Makefile b/bin/Makefile > index 180a91b5..6c5f9b14 100644 > --- a/bin/Makefile > +++ b/bin/Makefile > @@ -66,10 +66,10 @@ pve6to7.1: > > pve7to8.1: > printf ".TH PVE7TO8 1\n.SH NAME\npve7to8 \- Proxmox VE upgrade checker script for 7.4+ to current 8.x\n" > $@.tmp > - printf ".SH DESCRIPTION\nThis tool will help you to detect common pitfalls and misconfguration\ > - before, and during the upgrade of a Proxmox VE system\n" >> $@.tmp > - printf "Any failure must be addressed before the upgrade, and any waring must be addressed, \ > - or at least carefully evaluated, if a false-positive is suspected\n" >> $@.tmp > + printf ".SH DESCRIPTION\nThis tool will help you detect common pitfalls and misconfigurations\ > + before and during the upgrade of a Proxmox VE system.\n" >> $@.tmp > + printf "Any failures or warnings must be addressed prior to the upgrade.\n" >> $@.tmp Nit: "All failures and warnings" sounds slightly better IMHO > + printf "If you think that a message is a false-positive for your setup, double-check that before proceeding.\n" >> $@.tmp The old wording was a bit stronger: - with the new wording, failures and warnings are put into the same bucket - I do like the "carefully evaluated" more than a simple "double-check" > printf ".SH SYNOPSIS\npve7to8 [--full]\n" >> $@.tmp > mv $@.tmp $@ > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel