From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7B0898E3F5 for ; Fri, 11 Nov 2022 10:05:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5B48F24C for ; Fri, 11 Nov 2022 10:05:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 11 Nov 2022 10:05:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D8182402A7 for ; Fri, 11 Nov 2022 10:05:33 +0100 (CET) Message-ID: <468eef27-0215-0106-7a55-35118784aaa6@proxmox.com> Date: Fri, 11 Nov 2022 10:05:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 To: pve-devel@lists.proxmox.com References: <20220824162644.1632804-1-aderumier@odiso.com> <20220824162644.1632804-4-aderumier@odiso.com> <5d2c20cd70d460e4c8bbd800471434084bdac533.camel@groupe-cyllene.com> Content-Language: en-US From: Mira Limbeck In-Reply-To: <5d2c20cd70d460e4c8bbd800471434084bdac533.camel@groupe-cyllene.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.255 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH V3 qemu-server 1/3] tap_plug: add support for bridge disable learning X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2022 09:05:35 -0000 On 11/11/22 09:36, DERUMIER, Alexandre wrote: > Le mercredi 09 novembre 2022 à 15:19 +0100, Mira Limbeck a écrit : >> >> Why not add the bridge in the pve-bridge script as well? This way >> there >> would be no need for patch 2 for qemu-server since we always add the >> MAC >> address to the FDB whenever the tap device is plugged. >> >> If we then remove it in the pve-bridgedown script, there should be no >> need for patch 3, right? >> >> > ok, I review the whole patch serie, the current behaviour is good. > (Seem the workflow I have send in my previous comment on patch3) > > > We can't add fdb entry inconditionally in pve-bridge,as on live > migration, we don't want to add fdb entry until the migration is > finished. > > (If we do that, the others vms on the target host, will not be able to > communicate with source vms during the migration) > Wouldn't it still send the traffic to the source VM while the entry is still alive? But since you're a lot more knowledgeable about networks, I trust your judgement in this case. In this case consider the 3 qemu-server patches: Reviewed-by: Mira Limbeck Tested-by: Mira Limbeck The pve-network patch has only been tested without SDN for now, I'll try to set something up to test it with SDN as well. The pve-container patch is on my todo list as well.