From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BF3291FF171 for <inbox@lore.proxmox.com>; Fri, 15 Nov 2024 07:38:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8C0BBCF2E; Fri, 15 Nov 2024 07:38:21 +0100 (CET) Message-ID: <462e7e0d-e5b5-4af7-a0f5-6c59d6482dac@proxmox.com> Date: Fri, 15 Nov 2024 07:37:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20241114080435.241891-1-d.csapak@proxmox.com> <095563a0-f251-4fe8-9573-a27f5bb06330@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <095563a0-f251-4fe8-9573-a27f5bb06330@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH manager] ui: tree: show tooltips for all entries that have sensible information X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On 11/14/24 19:09, Thomas Lamprecht wrote: > Am 14.11.24 um 09:04 schrieb Dominik Csapak: >> instead of filtering pools and groups out manually, simply accumulate >> the info we want to to have (status/hastate/etc.) and if any of those >> exist, show the tooltip. >> >> This results in the nodes also having a tooltip, including their hastate >> (such as online/maintenance), and automatically would show such things >> in the future if we add those fields to other entries. >> >> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> >> --- >> www/manager6/tree/ResourceTree.js | 11 +++++++---- >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> > > applied, thanks! > > One minor thing I noticed, and where I'm rather unsure if we should do > anything about it, is some potential odd interaction between the tooltip > and the context menu, e.g. if I open the context menu of a node and then > move the cursor up to the node icon the tooltip pops up and is displayed > over the context menu and needs relatively long to hide. > But FWICT this was always the case for guests already anyway, so probably > it's just me overthinking this. Yeah I also think this was always the case, and IMHO it's not a huge issue. If we want to change that behavior, I'd suggest we disable the tree tooltips completely as long as a context menu is shown, but this can also be done later. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel