From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B73EA88053 for ; Tue, 4 Jan 2022 17:50:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A0FDE1EB8B for ; Tue, 4 Jan 2022 17:49:59 +0100 (CET) Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 246561EB7F for ; Tue, 4 Jan 2022 17:49:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1641314999; bh=hEq+1YW3Zk6pdWDENstTKt+Lb6ZJXNFW/iw5Sj2Szco=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=as81YJ1V8+9AHdGb0t3cLvfgYKhoGxJU47P9jvDuIWIyZKJA7ZB7i8zSpzUS0MgX/ bf9ddnNc+WQLVs/EQQLcmJpKAwGiQVMhpSGqqbiuy0Qpy1rBssCF3ctbxIfYcKI/0f 2bjVi0Y9mSH9RwOQ47sCNhfHtQsckgRzVFXqZ094= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [172.20.35.92] ([37.24.118.138]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Ml46y-1mfaZv0Kku-00ljRd; Tue, 04 Jan 2022 17:44:39 +0100 Message-ID: <462e37fd-5e74-e372-6cac-80069033a361@web.de> Date: Tue, 4 Jan 2022 17:44:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 To: Proxmox VE development discussion , Fabian Ebner , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20211222135257.3242938-1-f.gruenbichler@proxmox.com> <20211222135257.3242938-17-f.gruenbichler@proxmox.com> <5a3846bc-04bc-ed4d-4e2e-38a9911390aa@proxmox.com> From: Roland In-Reply-To: <5a3846bc-04bc-ed4d-4e2e-38a9911390aa@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:z4mQIUjAZkpO4OdEvi63QZZYY9dd4mFuuAr0ZvYI/+twdTYhT5G 5NSZHW6iqjPEk82vr/jaT7HlJBd5s2Jim4oa/Te4Rn+BBVGCbCgDOmdFWGoUTVeJsJFYVs7 R8ddcK4aPTELeoua87IbhSwdeJ/YNdzWNdaCuIBy9fcaQHmV08Jqn208SN6OcoBZPvBIYAw ms65KvY71ozOHQnIRMRgg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:MSYBguLirzY=:6I65mRMDjaAMWjrZDaIBNW Zz7Z0FoCfljyDQLf6GLreluTCrZ42TvKUAbUdjXxYNe3RSzlP1VVK1JG3HLPVIpgFfRpyyxes 8/oDASp2aUVfZ/n78xsZkyA52qDeK2Ni4UAfUosp951fQg2bvYQUBsGGEPhCDDlWXBe3Zafbc ANaYHmg23oi8CkqCH39LiBnvTHeJphypFQReLp4OFG98TdZPBlXQbuPpO2buTbo3W6eI7Rgra HhBkmC7ce6tZrT2HZj4tHPkIg07YqVnRK+IxW7nHGqzTv1K78xOd7bWEFJnpcYw9118TyQrh9 2lxnvWebESc/Bn2S7Y93BKzai5WnLac8VEDETADgnJTtcnoh/CVQEVI+w6hBKnhjM/dM5fESm mZmhoVpsRAJhaRWEttaIMeDaivUhI1BfpGTt33dR4mMdJJZlXe1ZD7+7c0p4/yY8QACyUL5zf NalkoIm4zKYpu7vADsXO862b3Mbnwst+wGyStqcqPP0OhxUDwU1wshbOujEC0Zy4fEG+jMnuU raqGrNW8TMogdtVOYQTRHgwzWf8/JlW2xZMZCIETeh72rlYl1zJwefx+vU8bx3/+DaecjXcvk ZJ+pvSh1Y3jllRFPRAWLiX037MVm5ML/ay/NBWPG7Vut1MYXTYdjzXbI6MpGlw7gHkvR+CMEB gEvTE7+syq+p2sEASm8v+pTy2qy7teKcwsSDJuTimhH31Kz8AEscs+pGEjlML8k9jWvv4/P7D snWh0bQDXJ8zr1sNk6BfPhcu9RnzZchLKtl3cHpXa7BRvuINxtmi3q7FI0QQ8izHYs1SOD2Fv AmARdrUjIHCTLUGqmfu9fyUDTrFPgnk87H7Pkojkz++/sWrGkKjaeiO5jvu/vfWcUnC75TW/+ j8LSPvFPLT+149AE2Vc1/LhyrFcjQ0g5/hTkzgosPVjYuf+bQ0WcOh70mTPnjHtKZkl/f0lBZ Ws/azLCqnBpethu9bZiEXZ6Qg5XanR20T7x/EuO79Hg7JpgwykaflHbOyi7m1NN+oRUTO9V4j HgQD1s+3b+mIxzc2K1gBmZRhsQpWoMk5XBZeSYBBdv7Hf0agwRyVg9ul262Hqg0n2E48xVLVo xzHwcyYz1WidNo= X-SPAM-LEVEL: Spam detection results: 0 AWL 3.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider NICE_REPLY_A -3.354 Looks like a legit reply (A) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust RCVD_IN_MSPIKE_H2 -0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v3 qemu-server 09/10] migrate: add remote migration handling X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2022 16:50:29 -0000 >> =C2=A0 +sub phase2_start_remote_cluster { >> +=C2=A0=C2=A0=C2=A0 my ($self, $vmid, $params) =3D @_; >> + >> +=C2=A0=C2=A0=C2=A0 die "insecure migration to remote cluster not imple= mented\n" >> +=C2=A0=C2=A0=C2=A0 if $params->{migrate_opts}->{type} ne 'websocket'; >> + >> +=C2=A0=C2=A0=C2=A0 my $remote_vmid =3D $self->{opts}->{remote}->{vmid}= ; >> + >> +=C2=A0=C2=A0=C2=A0 my $res =3D PVE::Tunnel::write_tunnel($self->{tunne= l}, 10, >> "start", $params); > > 10 seconds feels a bit short to me. > Please, administrators like tunables and knobs for changing default values= . Not only for being empowered to fix things themselves but also to be able to dig into a problem and find the root cause... I remember that i had more then one occasion , where i grepped for timeout or other limiting values in proxmox or other softwares source,=C2= =A0 and often gave up in the end, because it was too deeply hidden or i got too many hits/findings. Finding such without knowing the code can often be like searching for the needle in a haystack and extremely frustrating. I would be happy, if such important values would get defined with some descriptive variable name at a suitable location, maybe even with some comment what's it all about ( even if it's not meant to be changed/tuned) just my 10 cents... Roland