From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CBA061FF15E for <inbox@lore.proxmox.com>; Tue, 8 Apr 2025 10:10:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 99CF1D8BE; Tue, 8 Apr 2025 10:10:32 +0200 (CEST) Message-ID: <462ca272-2e83-418d-bec8-4bf60f56af31@proxmox.com> Date: Tue, 8 Apr 2025 10:10:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: pve-devel@lists.proxmox.com References: <20250407162718.495812-1-a.lauterer@proxmox.com> <20250407162718.495812-5-a.lauterer@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <20250407162718.495812-5-a.lauterer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v5 4/4] ui: console: check on activate if display info for VMs is present X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On 4/7/25 18:27, Aaron Lauterer wrote: > If we already have the display information for a VM, we can proceed > loading the correct console (noVNC or xtermjs). > > This way, we don't need to wait for the callback of the VM's > status/current API call to finish setting up the console. > > Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com> > --- > first introduces with v5 > > www/manager6/VNCConsole.js | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/www/manager6/VNCConsole.js b/www/manager6/VNCConsole.js > index 3371c923..60772373 100644 > --- a/www/manager6/VNCConsole.js > +++ b/www/manager6/VNCConsole.js > @@ -67,6 +67,14 @@ Ext.define('PVE.noVncConsole', { > activate: function() { > if (me.consoleType !== 'kvm') { > me.loadConsole(me.xtermjs, me.consoleType); > + } else { > + let display = me.up().statusStore.getById('display'); > + if (display && display.data.value.type?.startsWith('serial')) { this is the same check done in the other patch, no? a helper could be good here to make sure the checks stay in sync > + me.xtermjs = true; > + } > + if (display) { > + me.loadConsole(me.xtermjs, me.consoleType); > + } > } > }, > }, _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel