From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 921738E4C9 for ; Fri, 11 Nov 2022 14:58:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 788464392 for ; Fri, 11 Nov 2022 14:58:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 11 Nov 2022 14:58:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 086F443626 for ; Fri, 11 Nov 2022 14:58:34 +0100 (CET) Message-ID: <46120094-b291-a817-25a6-a0242f271f8a@proxmox.com> Date: Fri, 11 Nov 2022 14:58:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20221110153341.494439-1-s.hanreich@proxmox.com> From: Daniel Tschlatscher In-Reply-To: <20221110153341.494439-1-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.151 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [guest-example-hookscript.pl, lxc.pm, qemu.pm] Subject: Re: [pve-devel] [PATCH v2 pve-container/qemu-server/pve-docs] Add pre/post-restore hooks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2022 13:58:35 -0000 The new hookscript example works nicely out of the box. I tested restore for both VMs and containers via the GUI, the restore and create commands in the respective CLI commands and with the API. One thing which might some more consideration: When restoring a backup that does not configure a hookscript, the 'pre-restore' hook will run, however, the 'post-restore' will not. This was very confusing at first. Similarly, if the config does not include a hookscript, but the backup does, then the 'pre-restore' will not run but the 'post-restore' will. While this is not breaking, it is definitely very unexpected for an unsuspecting user. Otherwise, the core part of the series works as intended, therefore: Tested-by: Daniel Tschlatscher On 11/10/22 16:33, Stefan Hanreich wrote: > This patch adds hooks that run when the user restores a backup from the Web UI > / CLI. I have tested this with both VMs/CTs via Web UI and CLI. Are there any > other places where the hook should get triggered that I missed? > > Changes compared to v1: > - slightly moved the call site of the exec_hookscript in qemu-server and > pve-container, so necessary checks are run before the hookscript runs. > > > pve-container: > > Stefan Hanreich (1): > Add pre/post-restore hooks to CTs > > src/PVE/API2/LXC.pm | 7 +++++++ > 1 file changed, 7 insertions(+) > > > pve-docs: > > Stefan Hanreich (1): > add pre/post-restore events to example hookscript > > examples/guest-example-hookscript.pl | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > > qemu-server: > > Stefan Hanreich (1): > Add pre/post-restore hooks to VMs > > PVE/API2/Qemu.pm | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) >