From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 03DCE71D3D for ; Fri, 9 Apr 2021 14:52:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EA3FC26D89 for ; Fri, 9 Apr 2021 14:52:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 58D3D26D7A for ; Fri, 9 Apr 2021 14:52:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 20EA041FB0 for ; Fri, 9 Apr 2021 14:52:09 +0200 (CEST) To: Thomas Lamprecht , Proxmox VE development discussion References: <20210407102537.28046-1-f.ebner@proxmox.com> <355acdcc-b4d6-41c2-05d2-59cd637043e7@proxmox.com> From: Fabian Ebner Message-ID: <45f1ce6f-cb60-8341-b023-803069716806@proxmox.com> Date: Fri, 9 Apr 2021 14:52:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <355acdcc-b4d6-41c2-05d2-59cd637043e7@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.008 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [plugin.pm, proxmox.com] Subject: Re: [pve-devel] applied: [PATCH storage 1/2] plugin: subdir files: backup: don't match for vmid against the full path X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2021 12:52:11 -0000 Am 09.04.21 um 12:51 schrieb Thomas Lamprecht: > On 07.04.21 12:25, Fabian Ebner wrote: >> Only match against the file name to avoid false positives with directory names >> containing "-$vmid-". >> >> Signed-off-by: Fabian Ebner >> --- >> >> Found while trying to debug/reproduce a forum thread[0], but the path there >> should not be affected by this... >> >> [0]: https://forum.proxmox.com/threads/vzdump-removing-too-many-backups.87072/ >> >> PVE/Storage/Plugin.pm | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> > > applied, moved the comment up in the commit message, thanks! > Thanks for that and the follow-ups! Let's hope nobody sees those messages ;)