From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 90A7E1FF179 for ; Wed, 29 Oct 2025 10:16:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4BF0142AB; Wed, 29 Oct 2025 10:17:29 +0100 (CET) Message-ID: <45e140a2-8944-4018-82a1-626da3cf77d7@proxmox.com> Date: Wed, 29 Oct 2025 10:16:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Wolfgang Bumiller References: <20251007122509.66194-1-f.ebner@proxmox.com> <20251007122509.66194-2-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761729402903 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH common v3 1/2] systemd: add sd_notify() helper X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 28.10.25 um 3:58 PM schrieb Wolfgang Bumiller: > On Tue, Oct 07, 2025 at 02:25:00PM +0200, Fiona Ebner wrote: >> @@ -282,4 +285,32 @@ sub write_ini { >> file_set_contents($filename, $content); >> } >> >> +# This is a pure Perl reimplementation of systemd's sd_notify() as defined in systemd/sd-daemon.h >> +sub sd_notify { >> + my ($unset_environment, $state) = @_; >> + >> + my $socket_path = $ENV{NOTIFY_SOCKET}; > > Technically this could be an abstract socket. Should be enough to just > > $socket_path =~ s/^@/\0/; Will do in v4! > >> + >> + my $socket = IO::Socket::UNIX->new( >> + Type => SOCK_DGRAM(), >> + Peer => $socket_path, >> + ) or die "unable to connect to socket $socket_path to notify systemd - $IO::Socket::errstr\n"; >> + >> + # we won't be reading from the socket >> + $socket->shutdown(SHUT_RD); >> + >> + my $sent = 0; >> + my $total = length($state); >> + while ($sent < $total) { >> + my $res = $socket->send($state); >> + die "sending to $socket_path failed - $!" if !$res && $! != EINTR; >> + $sent += $res if $res; > > ^ This is a datagram socket. Systemd expects a single datagram. > The code sort of makes it look like you're trying doing a `write_all()` > style send (without actually changing what it sent in between calls > which wouldn't return zero). > Trying to continue sending in a fragmented way won't work anyway. > (Otherwise it would be rather cumbersome, since the protocol also allows > adding things like file descriptors to store in the fd registry; data > and metadata need to come in one nice bundle) > > The example code in the referenced man page errors out with `-EPROTO` if > the length does not match, so we could do that as well. > > So basically, only an EINTR loop makes sense here. Yes, I messed that up. Thank you for the explanation and suggestions! > >> + } >> + $socket->flush(); > > This should not be necessary, this is not buffered I/O. Ack! >> + >> + close($socket); >> + >> + delete($ENV{NOTIFY_SOCKET}) if $unset_environment; > > Why is this part of this function, though? Because I wanted to match the signature of the original sd_notify(), but actually it already doesn't match because of the return value. I guess I'll drop it for now since the examples in 'man 3 sd_notify' also don't have it. If a future caller needs it, it could also unset the variable itself. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel