From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1DCAB1FF173 for ; Mon, 11 Nov 2024 14:19:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3325CB6FC; Mon, 11 Nov 2024 14:19:38 +0100 (CET) Message-ID: <456382dd-aece-4686-9d36-50164100ce89@proxmox.com> Date: Mon, 11 Nov 2024 14:19:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Timothy Nicholson References: <20241111094050.22619-1-t.nicholson@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20241111094050.22619-1-t.nicholson@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy GAPPY_SUBJECT 0.1 Subject: contains G.a.p.p.y-T.e.x.t KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH widget-toolkit] fix #5831: ui: right-align s.m.a.r.t numerical table data X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" one comment inline On 11/11/24 10:40, Timothy Nicholson wrote: > This patch right-aligns the numerical values of the table displaying > the S.M.A.R.T values in the Web UI. > > Signed-off-by: Timothy Nicholson > --- > > For better readability, numerical values in tables should be > right-aligned, not like previously (left-aligned). > https://bugzilla.proxmox.com/show_bug.cgi?id=5831 > > src/window/DiskSmart.js | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js > index 9096fec..363ae28 100644 > --- a/src/window/DiskSmart.js > +++ b/src/window/DiskSmart.js > @@ -29,6 +29,7 @@ Ext.define('Proxmox.window.DiskSmart', { > text: 'ID', > dataIndex: 'id', > width: 50, > + align: 'right', > }, > { > text: gettext('Attribute'), > @@ -40,21 +41,25 @@ Ext.define('Proxmox.window.DiskSmart', { > text: gettext('Value'), > dataIndex: 'real-value', > renderer: Ext.String.htmlEncode, > + align: 'right',) this (real-value) is the raw value from smartctl, and this is not a "numerical" value, but more or less a freeform field. (e.g. i have some here with: '35 (Min/Max 17/35)') So I'd argue that this should not be right aligned looking at smartctl output, only ID is right aligned and normalized/threshold/worst are 0 padded (so those are fine to right align) > }, > { > text: gettext('Normalized'), > dataIndex: 'real-normalized', > width: 60, > + align: 'right', > }, > { > text: gettext('Threshold'), > dataIndex: 'threshold', > width: 60, > + align: 'right', > }, > { > text: gettext('Worst'), > dataIndex: 'worst', > width: 60, > + align: 'right', > }, > { > text: gettext('Flags'), _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel