From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6B0546BEA2 for ; Tue, 21 Sep 2021 15:46:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5C0FBF1DF for ; Tue, 21 Sep 2021 15:46:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6D541F1D1 for ; Tue, 21 Sep 2021 15:46:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3B90A43481 for ; Tue, 21 Sep 2021 15:46:06 +0200 (CEST) To: Proxmox VE development discussion , Dominik Csapak References: <20210920122338.840436-1-d.csapak@proxmox.com> From: Lorenz Stechauner Message-ID: <4546920c-d582-e1cf-1b47-3623892c43e5@proxmox.com> Date: Tue, 21 Sep 2021 15:46:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210920122338.840436-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.420 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH manager 00/10] multi tab disk panel & multi disk wizard X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2021 13:46:07 -0000 Hi, tested this series a bit. everything seems to work as advertised, except the VM creation wizard. After submitting I get an error: Parameter verification failed. (400) textfield-4006-inputEl: property is not defined in schema and the schema does not allow additional properties other small detail: width of the Bus/Device field for the bus nr. is too short to display two digit numbers. On 20.09.21 14:23, Dominik Csapak wrote: > this series is intended to replace dominics and my previous attempts > at this [0][1][2] > > splits the bandwidth options into their on tab on the disk panel and > introduces a 'MultiHDEdit' panel which creates/deletes the > HDEdit panels on demand. > > The UX is modeled after Dominics first attempt, but a very different > approach code-wise. instead of having a seperate 'data' panel that > contains the vm config, let the multi disk panel handle that > and pass it through to the panels below. this way the HDEdit does > not need a big code-change to get/set the config. > > 0: https://lists.proxmox.com/pipermail/pve-devel/2021-June/048690.html > 1: https://lists.proxmox.com/pipermail/pve-devel/2021-July/049295.html > 2: https://lists.proxmox.com/pipermail/pve-devel/2021-September/050013.html > > Dominik Csapak (10): > ui: qemu/HDEdit: move Bandwidth options to a different tab > ui: form/ControllerSelector: set correct max value for the device-id > ui: refactor sortByPreviousUsage and nextFreeDisk > ui: form/ControllerSelector: add updateVMConfig and getConfId > ui: qemu/HDEdit: use me instead of this > ui: qemu/HDEdit: fire an event when the disk id changes > ui: qemu/OSTypeEdit: drop throwing an error on multiple widgets > ui: Utils: add capture group for the id in bus_match > ui: form/ControllerSelector: add option for selecting free on inital > config > ui: add qemu/MultiHDEdit and use it in the wizard > > www/manager6/Makefile | 1 + > www/manager6/Utils.js | 48 +++- > www/manager6/form/ControllerSelector.js | 65 +++--- > www/manager6/qemu/CreateWizard.js | 4 +- > www/manager6/qemu/HDEdit.js | 143 ++++++++---- > www/manager6/qemu/MultiHDEdit.js | 291 ++++++++++++++++++++++++ > www/manager6/qemu/OSTypeEdit.js | 2 +- > www/manager6/window/Wizard.js | 5 +- > 8 files changed, 477 insertions(+), 82 deletions(-) > create mode 100644 www/manager6/qemu/MultiHDEdit.js >