From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5FF66BB55 for ; Mon, 2 May 2022 09:12:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 56AB224A97 for ; Mon, 2 May 2022 09:11:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D8DBC24A8C for ; Mon, 2 May 2022 09:11:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ADDFC4265B; Mon, 2 May 2022 09:11:56 +0200 (CEST) Message-ID: <453f8ec1-4b40-0f86-ed1f-c2a79e3e53c3@proxmox.com> Date: Mon, 2 May 2022 09:11:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20220429141655.2884387-1-a.lauterer@proxmox.com> <20220429141655.2884387-2-a.lauterer@proxmox.com> From: Dominik Csapak In-Reply-To: <20220429141655.2884387-2-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.096 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.943 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager 2/4] api: ceph pools: add type to returned properties X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2022 07:12:27 -0000 one nit inline On 4/29/22 16:16, Aaron Lauterer wrote: > The osd dump already contains the pool type in numerical format. > > Signed-off-by: Aaron Lauterer > --- > PVE/API2/Ceph/Pools.pm | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/PVE/API2/Ceph/Pools.pm b/PVE/API2/Ceph/Pools.pm > index efdee360..b93f87e4 100644 > --- a/PVE/API2/Ceph/Pools.pm > +++ b/PVE/API2/Ceph/Pools.pm > @@ -66,6 +66,11 @@ __PACKAGE__->register_method ({ > type => 'integer', > title => 'Size', > }, > + type => { > + type => 'string', > + title => 'Type', > + enum => ['replicated', 'erasure', 'unknown'], > + }, > min_size => { > type => 'integer', > title => 'Min Size', > @@ -185,6 +190,15 @@ __PACKAGE__->register_method ({ > $d->{bytes_used} = $s->{bytes_used}; > $d->{percent_used} = $s->{percent_used}; > } > + > + if ($e->{type} == 1) { > + $d->{type} = 'replicated'; > + } elsif ($e->{type} == 3) { > + $d->{type} = 'erasure'; > + } else { > + # we should never get here, but better be safe > + $d->{type} = 'unknown'; > + } i remember we talked off-list about those '1' / '3' values, but is there any reference we can use to document these? (as comment or commit message) even if it's only a link to some github or refence to a file in some commit hash of ceph, that way we can easily look it up if it changes also what would be value '2' ? > push @$data, $d; > } >