From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A106D6342A for ; Mon, 21 Sep 2020 14:09:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E9F525419 for ; Mon, 21 Sep 2020 14:09:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DCE072540C for ; Mon, 21 Sep 2020 14:09:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 85E2F45477 for ; Mon, 21 Sep 2020 14:09:16 +0200 (CEST) To: Proxmox VE development discussion , Aaron Lauterer References: <20200910143242.20898-1-a.lauterer@proxmox.com> <20200910143242.20898-5-a.lauterer@proxmox.com> From: Thomas Lamprecht Message-ID: <44c93a7c-576e-3983-b13a-5ebb49388c27@proxmox.com> Date: Mon, 21 Sep 2020 14:09:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Thunderbird/81.0 MIME-Version: 1.0 In-Reply-To: <20200910143242.20898-5-a.lauterer@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.186 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v3 widget-toolkit 4/4] utils: task_desc_table: add qmreassign X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 12:09:48 -0000 On 10.09.20 16:32, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > rfc -> v1 -> v2 -> v3: nothing changed >=20 > src/Utils.js | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/src/Utils.js b/src/Utils.js > index 8595cce..af41f33 100644 > --- a/src/Utils.js > +++ b/src/Utils.js > @@ -587,6 +587,7 @@ utilities: { > qmigrate: ['VM', gettext('Migrate')], > qmclone: ['VM', gettext('Clone')], > qmmove: ['VM', gettext('Move disk')], > + qmreassign: ['VM', gettext('Reassign disk')], > qmtemplate: ['VM', gettext('Convert to template')], > qmstart: ['VM', gettext('Start')], > qmstop: ['VM', gettext('Stop')], >=20 I'd like to avoid adding new project specific task descriptions in widget= toolkit. Rather use the Proxmox.Utils.override_task_descriptions [0] in pve-manage= r to add such project specific task descriptions. See Proxmox Backup Server UI for= an usage example [1]. [0]: https://git.proxmox.com/?p=3Dproxmox-widget-toolkit.git;a=3Dblob;f=3D= src/Utils.js;h=3D8595ccec41e00aed5790af1a6ad5cfcd0e35674c;hb=3DHEAD#l653 [1]: https://git.proxmox.com/?p=3Dproxmox-backup.git;a=3Dblob;f=3Dwww/Uti= ls.js;h=3D7bcf1ba613fb6d0c52d7d862ba0d0264f1b738c0;hb=3DHEAD#l93