From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 915099B13A for ; Mon, 20 Nov 2023 09:07:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 73F05151BD for ; Mon, 20 Nov 2023 09:07:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 20 Nov 2023 09:07:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4B33843329 for ; Mon, 20 Nov 2023 09:07:41 +0100 (CET) Message-ID: <4433c961-2a08-402f-b0a9-22d5e60ce816@proxmox.com> Date: Mon, 20 Nov 2023 09:07:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Content-Language: en-US From: Dominik Csapak To: pve-devel@lists.proxmox.com Reply-To: Proxmox VE development discussion References: <20231120080242.443263-1-d.csapak@proxmox.com> In-Reply-To: <20231120080242.443263-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager] ui: fix zero-sized panels on fresh chrome start X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2023 08:07:42 -0000 On 11/20/23 09:02, Dominik Csapak wrote: > it seems in new versions of chrome , this triggers too early on a fresh > start (when autostarting a pve tab), resulting in the > 'viewWidth'/'viewHeight' being zero pixels. This means we set the width > of the left and the height of the bottom panel to zero pixels, making > them functionally invisible. > > To prevent that, check that the 'viewWidth'/'viewHeight' is big enough > so that the panels still have least 50 pixels left before setting their > size. > > reported on the pve-user list: > https://lists.proxmox.com/pipermail/pve-user/2023-November/017292.html this actually is a different issue, i misunderstood the message from the user... anyway it's a problem i can reproduce here quite easily, so i guess somebody else will trigger it sooner or later > > Signed-off-by: Dominik Csapak > --- > this plaged me for at least a week, but it seems no one else ran into > this, so i blamed my local install, until the report on pve-user > > we should probably backport this to stable-7, can send a separate fix > should it not cleanly apply/be cherry-pickable > > www/manager6/Workspace.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js > index 6e465f8d..89ca47b7 100644 > --- a/www/manager6/Workspace.js > +++ b/www/manager6/Workspace.js > @@ -485,7 +485,7 @@ Ext.define('PVE.StdWorkspace', { > listeners: { > resize: function(panel, width, height) { > var viewWidth = me.getSize().width; > - if (width > viewWidth - 100) { > + if (width > viewWidth - 100 && viewWidth > 150) { > panel.setWidth(viewWidth - 100); > } > }, > @@ -506,7 +506,7 @@ Ext.define('PVE.StdWorkspace', { > listeners: { > resize: function(panel, width, height) { > var viewHeight = me.getSize().height; > - if (height > viewHeight - 150) { > + if (height > viewHeight - 150 && viewHeight > 200) { > panel.setHeight(viewHeight - 150); > } > },