From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 5F87D1FF140
	for <inbox@lore.proxmox.com>; Fri, 27 Mar 2026 10:57:46 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id A2513225A;
	Fri, 27 Mar 2026 10:58:09 +0100 (CET)
Message-ID: <43fd0311-2dba-48c9-9bf4-7ebdc27f20c0@proxmox.com>
Date: Fri, 27 Mar 2026 10:57:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH pve-network 06/13] api2: add route map module
To: Hannes Laimer <h.laimer@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260325094142.174364-1-s.hanreich@proxmox.com>
 <20260325094142.174364-21-s.hanreich@proxmox.com>
 <9204be9e-1dbd-43fb-84ea-3f0c5570a99f@proxmox.com>
Content-Language: en-US
From: Stefan Hanreich <s.hanreich@proxmox.com>
In-Reply-To: <9204be9e-1dbd-43fb-84ea-3f0c5570a99f@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.562 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	POISEN_SPAM_PILL          0.1 Meta: its spam
	POISEN_SPAM_PILL_1        0.1 random spam to be learned in bayes
	POISEN_SPAM_PILL_3        0.1 random spam to be learned in bayes
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: KMEIOGL4SJD2EAQ2HQHKOBKKBRAHS7T3
X-Message-ID-Hash: KMEIOGL4SJD2EAQ2HQHKOBKKBRAHS7T3
X-MailFrom: s.hanreich@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>



On 3/26/26 4:06 PM, Hannes Laimer wrote:
> On 2026-03-25 10:44, Stefan Hanreich wrote:
>> This module contains the following API endpoint:
>>
>> GET /route-maps/<id> - lists all route map entries for the route map
>> <id>
>>
>> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
>> ---
> 
> [..]
> 
>> +__PACKAGE__->register_method({
>> +    name => 'list_route_map_entries',
>> +    path => '',
>> +    method => 'GET',
>> +    permissions => {
>> +        check => ['perm', '/sdn/route-maps/{route_map_id}', ['SDN.Audit']],
>> +    },
>> +    description => "List all entries for a given Route Map",
> 
> [..]
> 
>> +    code => sub {
>> +        my ($param) = @_;
>> +
>> +        my $pending = extract_param($param, 'pending');
>> +        my $running = extract_param($param, 'running');
>> +        my $route_map_id = extract_param($param, 'route-map-id');
>> +
>> +        my $digest;
>> +        my $route_map_entries;
>> +
>> +        if ($pending) {
>> +            my $current_config = PVE::Network::SDN::RouteMaps::config()->list_route_map($route_map_id);
>> +            my $running_config = PVE::Network::SDN::RouteMaps::config(1)->list_route_map($route_map_id);
>> +
>> +            my $pending_route_maps = PVE::Network::SDN::pending_config(
>> +                $running_config,
>> +                $current_config,
> 
> we should wrap these two, like pve-network 03/13 :P

fixed in the same vein as 3/13