From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6C448755BC for ; Wed, 21 Apr 2021 18:17:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 609A1121B6 for ; Wed, 21 Apr 2021 18:16:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A81BD1219E for ; Wed, 21 Apr 2021 18:16:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 84F5F461F7 for ; Wed, 21 Apr 2021 18:16:42 +0200 (CEST) Message-ID: <434d2f5d-f6ed-6033-3f00-6c488510e86d@proxmox.com> Date: Wed, 21 Apr 2021 18:16:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Proxmox VE development discussion , Oguz Bektas , pve-devel@pve.proxmox.com References: <99c76ae4-0810-f44d-25c4-3cdf8ce28dc0@proxmox.com> <20210324132036.592880-1-o.bektas@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210324132036.592880-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.251 Adjusted score from AWL reputation of From: address CTE_8BIT_MISMATCH 0.001 Header says 7bits but body disagrees KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [perl.org, daemon.pm] Subject: [pve-devel] applied: [PATCH v4 common 1/3] daemon: listen also on ipv6 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2021 16:17:16 -0000 On 24.03.21 14:20, Oguz Bektas wrote: > see [0] > when we set 'Domain' to PF_INET6 by default, it will prefer IPv6. since > we don't set 'V6Only' it will also listen on IPv4 interfaces. > > 'Family' parameter isn't needed anymore. > > this change depends on the changes in pve-manager and pve-http-server to > work correctly. > > [0]: > https://perldoc.perl.org/IO::Socket::IP#REPLACING-IO::Socket-DEFAULT-BEHAVIOUR > > Signed-off-by: Oguz Bektas > --- > v3->v4: > * remove $family parameter > > src/PVE/Daemon.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > applied, thanks! but please do not send new patch versions to a sub-thread with in-reply-to, that's in general just easier to overlook and thus get lost and harder to piece together a series on applying. General note: the pveproxy needs to be restarted, not reloaded, for this change to be applied. Was a bit thrown off by that, as installing this and the updated pve-manager package only triggered a reload and the process kept listening on the "old" local address (0.0.0.0:8006) vs. the always-correct™ *:8006 one