From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6D72C7228A for ; Tue, 15 Jun 2021 10:37:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D8062BC6B for ; Tue, 15 Jun 2021 10:36:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6E6C92BC60 for ; Tue, 15 Jun 2021 10:36:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3546842BC6 for ; Tue, 15 Jun 2021 10:36:31 +0200 (CEST) To: Fabian Ebner , Proxmox VE development discussion References: <20210413082414.32241-1-f.ebner@proxmox.com> <78d32c42-cb8e-49e8-66e3-590669333fd5@proxmox.com> <4d66d415-ef78-e3c7-2469-59b93ee37c6b@proxmox.com> From: Stefan Reiter Message-ID: <434345c4-8608-5fd4-5955-5285bc394ec7@proxmox.com> Date: Tue, 15 Jun 2021 10:36:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <4d66d415-ef78-e3c7-2469-59b93ee37c6b@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.489 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, proxmox.com] Subject: Re: [pve-devel] [RFC qemu-server] avoid setting lun number for drives when pvscsi controller is used X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jun 2021 08:37:02 -0000 On 6/15/21 10:04 AM, Fabian Ebner wrote: > Am 14.06.21 um 11:15 schrieb Stefan Reiter: >> On 6/14/21 8:29 AM, Fabian Ebner wrote: >>> Any feedback for this? >>> >> >> Looks good to me and works as advertised: >> >> Reviewed-by: Stefan Reiter >> Tested-by: Stefan Reiter >> > > Thanks for the review! > >> The `$unit = $drive->{index} % maxdev` logic doesn't seem useful here >> though, I >> think it's a copy/paste from the IDE/SATA code below (it was already >> used before >> this patch). How about this for a cleanup on top: >> > >> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm >> index c00bde1..afd47b5 100644 >> --- a/PVE/QemuServer.pm >> +++ b/PVE/QemuServer.pm >> @@ -1424,7 +1424,6 @@ sub print_drivedevice_full { >>      } elsif ($drive->{interface} eq 'scsi') { >> >>      my ($maxdev, $controller, $controller_prefix) = >> scsihw_infos($conf, $drive); >> -    my $unit = $drive->{index} % $maxdev; > > > Using LSI 53C895A controller and 9 disks I get > > kvm: -device > scsi-hd,bus=scsihw1.0,scsi-id=8,drive=drive-scsi8,id=scsi8: bad scsi > device id: 8 > > As long as scsihw_infos returns the correct thing, I don't see a problem > sticking to the modular arithmetic ;) > Ah yes, the LSI ones get a new controller every 8 drives, and with pvscsi $maxdev is 256 anyway... alright, ignore this then :) >>      my $devicetype = 'hd'; >>      my $path = ''; >>      if (drive_is_cdrom($drive)) { >> @@ -1452,7 +1451,7 @@ sub print_drivedevice_full { >>      } >> >>      if (!$conf->{scsihw} || $conf->{scsihw} =~ m/^lsi/ || >> $conf->{scsihw} eq 'pvscsi') { >> -       $device = >> "scsi-$devicetype,bus=$controller_prefix$controller.0,scsi-id=$unit"; >> +       $device = >> "scsi-$devicetype,bus=$controller_prefix$controller.0,scsi-id=$drive->{index}"; >> >>      } else { >>         $device = >> "scsi-$devicetype,bus=$controller_prefix$controller.0,channel=0,scsi-id=0" >>             .",lun=$drive->{index}"; >> >> >>> Am 13.04.21 um 10:24 schrieb Fabian Ebner: >>>> Reported in the community forum[0]. >>>> >>>> In QEMU's hw/scsi/vmw_pvscsi.c in the SCSIBusInfo struct, the max_lun >>>> property >>>> is set to 0. This means that in our stack, one cannot have multiple >>>> disks and >>>> use 'scsihw: pvscsi' currently, as kvm would fail with >>>>       bad scsi device lun: 1 >>>> >>>> Instead of increasing the lun number, increase the scsi-id, as we >>>> already do for >>>> lsi.* (in hw/scsi/lsi53c895a.c the max_lun property is also 0). >>>> >>>> [0]: https://forum.proxmox.com/threads/kvm-bad-scsi-device-lun-1.84318/ >>>> >>>> Signed-off-by: Fabian Ebner >>>> --- >>>> >>>> I'm not experienced in this area, so not at all sure if this is the >>>> proper >>>> solution/workaround. >>>> >>>>    PVE/QemuServer.pm | 2 +- >>>>    1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm >>>> index fdb2ac9..4ce663b 100644 >>>> --- a/PVE/QemuServer.pm >>>> +++ b/PVE/QemuServer.pm >>>> @@ -1451,7 +1451,7 @@ sub print_drivedevice_full { >>>>            } >>>>        } >>>> -    if (!$conf->{scsihw} || ($conf->{scsihw} =~ m/^lsi/)){ >>>> +    if (!$conf->{scsihw} || $conf->{scsihw} =~ m/^lsi/ || >>>> $conf->{scsihw} eq 'pvscsi') { >>>>            $device = >>>> "scsi-$devicetype,bus=$controller_prefix$controller.0,scsi-id=$unit"; >>>>        } else { >>>>            $device = >>>> "scsi-$devicetype,bus=$controller_prefix$controller.0,channel=0,scsi-id=0" >>>> >>>> >>> >>> >>> _______________________________________________ >>> pve-devel mailing list >>> pve-devel@lists.proxmox.com >>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >>> >>>