From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E1949A14BF for ; Wed, 14 Jun 2023 14:52:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BAE2A1C76E for ; Wed, 14 Jun 2023 14:51:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 14 Jun 2023 14:51:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0830F45325 for ; Wed, 14 Jun 2023 14:51:52 +0200 (CEST) Message-ID: <4331ed65-7014-cbb3-9ae6-245a3bb293cc@proxmox.com> Date: Wed, 14 Jun 2023 14:51:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Proxmox VE development discussion , Alexander Zeidler References: <20230613134254.153081-1-a.zeidler@proxmox.com> <20230613134254.153081-5-a.zeidler@proxmox.com> From: Fiona Ebner In-Reply-To: <20230613134254.153081-5-a.zeidler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.098 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [common.pm] Subject: Re: [pve-devel] [PATCH guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jun 2023 12:52:22 -0000 Am 13.06.23 um 15:42 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > src/PVE/VZDump/Common.pm | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm > index a6fe483..28ab0d3 100644 > --- a/src/PVE/VZDump/Common.pm > +++ b/src/PVE/VZDump/Common.pm > @@ -282,6 +282,12 @@ my $confdesc = { > requires => 'storage', > optional => 1, > }, > + "pbs-entries-max" => { > + type => 'integer', > + description => "Override max number of entries to hold in memory (only applicable for PBS).", > + optional => 1, > + minimum => 1, > + }, > }; Now I'm wondering if this would make sense as part of the 'performance' setting? Depending on how you interpret it, it could fit or not. Any other opinions?