From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 2DB7E96989
 for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 12:57:05 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 075C618306
 for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 12:56:35 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 12:56:34 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3F394455B3
 for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 12:56:34 +0200 (CEST)
Message-ID: <42c7fdd9-76f8-4c18-ac38-d711312c5f90@proxmox.com>
Date: Tue, 16 Apr 2024 12:56:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Filip Schauer <f.schauer@proxmox.com>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20240416092717.60511-1-f.schauer@proxmox.com>
 <2dc344e6-2ec4-407a-b627-2ea83ae48005@proxmox.com>
Content-Language: en-US
In-Reply-To: <2dc344e6-2ec4-407a-b627-2ea83ae48005@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.071 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] applied: [PATCH v3 container] fix invalid device
 passthrough being added to config
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2024 10:57:05 -0000

Am 16.04.24 um 12:47 schrieb Fiona Ebner:
> Am 16.04.24 um 11:27 schrieb Filip Schauer:
>> diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
>> index 5ac1446..408140f 100644
>> --- a/src/PVE/LXC/Config.pm
>> +++ b/src/PVE/LXC/Config.pm
>> @@ -3,7 +3,8 @@ package PVE::LXC::Config;
>>  use strict;
>>  use warnings;
>>  
>> -use Fcntl qw(O_RDONLY);
>> +use Errno qw(ENOENT);
>> +use Fcntl qw(O_RDONLY :mode);
>>  
>>  use PVE::AbstractConfig;
>>  use PVE::Cluster qw(cfs_register_file);
> 
> I dropped the above hunk, because it's a left-over from a previous
> version AFAICT.
> 

And the LXC::Config module did not yet include LXC::Tools, added that
with a follow-up patch.