From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 755D21FF15D for ; Thu, 25 Jul 2024 15:25:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 716FE67A4; Thu, 25 Jul 2024 15:25:24 +0200 (CEST) Message-ID: <4269c802-c8d6-4eb2-9abf-2ef30366287f@proxmox.com> Date: Thu, 25 Jul 2024 15:25:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: Proxmox VE development discussion , Max Carrara References: <20240723095624.53621-1-f.ebner@proxmox.com> <20240723095624.53621-11-f.ebner@proxmox.com> <74a748f3-f7ff-4de5-aa1d-3378ae22c642@proxmox.com> Content-Language: en-US In-Reply-To: <74a748f3-f7ff-4de5-aa1d-3378ae22c642@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC storage 10/23] plugin: introduce new_backup_provider() method X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 25.07.24 um 15:11 schrieb Fiona Ebner: > Am 25.07.24 um 11:48 schrieb Max Carrara: >> For the specific types we can always then provide helper functions that >> handle common cases that implementors can use. >> >> Extending on my namespace idea above, those helpers could then land in >> e.g. `PVE::Backup::Provider::Common`, `PVE::Backup::Provider::Common::LXC`, >> etc. >> > > Could you give an example for such a helper? I rather feel like things > like libnbd will be that, i.e. for accessing the NBD export, not sure if > we can create common helpers that would benefit multiple providers, each > has their own backend they'll need to talk to after all and might have > quite different needs. Actually, this just gave me an idea (not for a helper method though :P). We can provide a simpler mechanism than NBD, by just exposing the block device with qemu-nbd ourselves first and also reading the bitmap ourselves first, then passing the path to the block device and the bitmap info to the provider. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel