From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EC6176BB4B for ; Fri, 19 Feb 2021 15:37:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E42A31A434 for ; Fri, 19 Feb 2021 15:37:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 85DB31A427 for ; Fri, 19 Feb 2021 15:37:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4D01F41A13 for ; Fri, 19 Feb 2021 15:37:39 +0100 (CET) Message-ID: <4248bdeb-a2bb-18cc-b8e5-2b5ce913d010@proxmox.com> Date: Fri, 19 Feb 2021 15:37:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Thunderbird/86.0 Content-Language: en-US To: Proxmox VE development discussion , Stoiko Ivanov References: <20210211181947.11368-1-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210211181947.11368-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.059 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [certificate.pm] Subject: [pve-devel] applied: [PATCH common] fix #3259: always free certificate file after reading it X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 14:37:40 -0000 On 11.02.21 19:19, Stoiko Ivanov wrote: > This commit mirrors e3c4007bc94956962c03da8c6853415d2fdf057c in > pve-cluster. The fix there got lost with a refactoring for reusing the > code here in pve-common in c92b771669e68a8b49906b8a0a68b533750567b0 > > Tested by repeadetly reading https://$pve-node:8006/nodes on a > virtual testcluster. > > Signed-off-by: Stoiko Ivanov > --- > src/PVE/Certificate.pm | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > applied, thanks!