From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5085B81AD1 for ; Thu, 25 Nov 2021 15:06:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F355E270 for ; Thu, 25 Nov 2021 15:06:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4077FE264 for ; Thu, 25 Nov 2021 15:06:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C96C146A7E for ; Thu, 25 Nov 2021 15:06:13 +0100 (CET) Message-ID: <42391428-bd80-2d55-5cb6-7c8ecd97a3a8@proxmox.com> Date: Thu, 25 Nov 2021 15:06:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak , Oguz Bektas References: <20211109141359.990235-1-o.bektas@proxmox.com> <20211109141359.990235-2-o.bektas@proxmox.com> From: Thomas Lamprecht In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 2.151 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -4.1 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [status.pm, fedorapeople.org] Subject: Re: [pve-devel] [PATCH storage 1/2] download-url: reuse http_proxy from datacenter.cfg for https X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Nov 2021 14:06:45 -0000 On 25.11.21 14:34, Dominik Csapak wrote: > LGTM and works :) >=20 in general has the same issue as the ACME one from Stoiko, namely: The original http_proxy was always for external resources (our repos/appl= iances, subscription checks), but this and the ACME ones aren't necesarrily exter= nal, and proxying them may break some stuff (not all enterprise setups have contro= l over the proxy to make it differ between internal/external resources) or be just u= ndesired. What I'm missing on this and the acme patch is to actually step back and = think proxying in PVE/PMG through, what are the different use cases, how can th= ey be grouped sensible and exposed to the admin. At leas acknowledging somethin= g like that in the commit message and giving some reasons about why that drawbac= k is accepted for now. I mean, Stoiko at least made it a per-acme-plugin decision if something s= hould get proxied through the datacenter configured proxy or not, but one may want = to have different too (albeit blowing it up per single smallest request-type is s= urely overkill). A https variant could be interesting too. One could imagine a format string like (disclaimer, made up on the spot):= proxy: http=3D<>,https=3D<>,apply-on=3D would be the original repo/appliances/subscriber coverage) > On 11/9/21 15:13, Oguz Bektas wrote: >> $ tail -f /var/log/squid/access.log >> ... >> 1636466926.415=C2=A0 42386 127.0.0.1 TCP_TUNNEL/200 557422779 CONNECT = fedorapeople.org:443 - HIER_DIRECT/152.19.134.199 - >> >> >> Signed-off-by: Oguz Bektas >> --- >> =C2=A0 PVE/API2/Storage/Status.pm | 1 + >> =C2=A0 1 file changed, 1 insertion(+) >> >> diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm >> index 02c970f..8eda39e 100644 >> --- a/PVE/API2/Storage/Status.pm >> +++ b/PVE/API2/Storage/Status.pm >> @@ -639,6 +639,7 @@ __PACKAGE__->register_method({ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hash_required =3D= > 0, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 verify_certific= ates =3D> $param->{'verify-certificates'} // 1, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 http_proxy =3D>= $dccfg->{http_proxy}, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 https_proxy =3D> $dccfg->{= http_proxy}, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }; >> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 my ($checksum, $checksum_algorit= hm) =3D $param->@{'checksum', 'checksum-algorithm'}; >>