From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1B0778D67B for ; Tue, 8 Nov 2022 17:47:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EA68EA636 for ; Tue, 8 Nov 2022 17:47:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 8 Nov 2022 17:47:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8F02440FFF for ; Tue, 8 Nov 2022 17:47:09 +0100 (CET) Message-ID: <41e61c00-ffa8-f4e9-fc35-dc13bae93b2e@proxmox.com> Date: Tue, 8 Nov 2022 17:47:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion , Daniel Tschlatscher References: <20220520080332.80155-1-o.bektas@proxmox.com> <56868828-dac3-945a-c3af-d2fcf32bc2f7@proxmox.com> From: Thomas Lamprecht In-Reply-To: <56868828-dac3-945a-c3af-d2fcf32bc2f7@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v6 manager] ui: vm network: allow to override MTU for virtio devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2022 16:47:41 -0000 Am 12/10/2022 um 10:57 schrieb Daniel Tschlatscher: > This patch still applies well and works as intended. > > There is one UI suggestion inline. > > > Tested-by: Daniel Tschlatscher > thx! >> @@ -161,6 +187,14 @@ Ext.define('PVE.qemu.NetworkInputPanel', { >> value: '', >> allowBlank: true, >> }, >> + { >> + xtype: 'displayfield', >> + userCls: 'pmx-hint', >> + value: gettext("Use the special value '1' to inherit the MTU value from the underlying bridge"), >> + bind: { >> + hidden: '{!showMtuHint}', >> + }, >> + }, > I think it might make a bit more sense to move this into the > advancedColumn1 as well, as now it is displayed in the opposite column, > which makes the UI flow kind of confusing. > Perhaps an even better option though, would be to move the displayfield > into an advancedColumnB, which would also remove the line width limit > and with it the somewhat ugly line break. > With Oguz not working here anymore, would you like to re-send this with that change?