From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C3DE66BC93 for ; Fri, 19 Feb 2021 16:28:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B75D31AD36 for ; Fri, 19 Feb 2021 16:28:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 55C861AD28 for ; Fri, 19 Feb 2021 16:28:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 254F84627F for ; Fri, 19 Feb 2021 16:28:33 +0100 (CET) Message-ID: <417fceba-5198-9276-3062-9a89a054bd9f@proxmox.com> Date: Fri, 19 Feb 2021 16:28:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Thunderbird/86.0 Content-Language: en-US To: Proxmox VE development discussion , Stoiko Ivanov References: <20210219124544.12593-1-s.ivanov@proxmox.com> <20210219124544.12593-4-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210219124544.12593-4-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.059 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zfspoolplugin.pm] Subject: [pve-devel] applied: [PATCH storage v2 3/3] zfspoolplugin: check if imported before importing X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 15:28:33 -0000 On 19.02.21 13:45, Stoiko Ivanov wrote: > This commit is a small performance optimization to the previous one: > `zpool list` is cheaper than `zpool import -d /dev..` (the latter > scans the disks in the provided directory for zfs signatures, > unconditionally) > > Signed-off-by: Stoiko Ivanov > --- > PVE/Storage/ZFSPoolPlugin.pm | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > applied, with the cleanups we talked off-list about, thanks!