From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7A8301FF187 for ; Mon, 20 Oct 2025 17:18:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E7FE9C51A; Mon, 20 Oct 2025 17:18:43 +0200 (CEST) Message-ID: <41443b75-98a6-4a48-afe4-22586474faa8@proxmox.com> Date: Mon, 20 Oct 2025 17:18:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Daniel Kral , Proxmox VE development discussion References: <20250930142021.366529-1-d.kral@proxmox.com> <20250930142021.366529-9-d.kral@proxmox.com> <2416d9fd-c47f-48c9-ac0b-c7f8e4d754ab@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760973514721 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH ha-manager 5/9] rules: resource affinity: decouple get_resource_affinity helper from Usage class X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 17.10.25 um 5:46 PM schrieb Daniel Kral: > On Fri Oct 17, 2025 at 1:14 PM CEST, Fiona Ebner wrote: >> Am 30.09.25 um 4:21 PM schrieb Daniel Kral: >>> diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm >>> index 468e41eb..0226e427 100644 >>> --- a/src/PVE/HA/Manager.pm >>> +++ b/src/PVE/HA/Manager.pm >>> @@ -121,12 +121,12 @@ sub flush_master_status { >>> >>> =head3 select_service_node(...) >>> >>> -=head3 select_service_node($rules, $online_node_usage, $sid, $service_conf, $sd, $node_preference) >>> +=head3 select_service_node($rules, $online_node_usage, $sid, $service_conf, $ss, $node_preference) >>> >> >> Pre-existing, but is this duplicate heading intentional? > > Yes, I picked it up from the Perl documentation RFC. This makes it > easier to reference it in perlpod when one can use only the short > heading instead of having to write out the heading with all of the > parameters, while the latter will be used for the LSP AFAICT (which I > actually don't use myself..). > > L<< selects the service's node|/select_service_node(...) >>> > > This one could be removed because currently it isn't used anywhere. Oh, good to know! I was just wondering, I'm fine either way. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel