From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 05ABD1FF13B for ; Wed, 11 Mar 2026 18:03:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 30FC733DF5; Wed, 11 Mar 2026 18:03:07 +0100 (CET) Message-ID: <40e8e151-a812-4041-a4de-b0a79098eb73@proxmox.com> Date: Wed, 11 Mar 2026 18:02:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH manager 1/1] ceph: osd: fix bootstrap keyring creation when auth_client_required is not in ceph.conf To: Kefu Chai , pve-devel@lists.proxmox.com References: <20260311132849.437725-2-k.chai@proxmox.com> <20260311132849.437725-3-k.chai@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260311132849.437725-3-k.chai@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773248512824 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.078 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IYBEBXMJJJIPOT7DZTTZFJOJFDZYBI32 X-Message-ID-Hash: IYBEBXMJJJIPOT7DZTTZFJOJFDZYBI32 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kefu Chai X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 11.03.26 um 14:29 schrieb Kefu Chai: > The condition guarding bootstrap-osd keyring creation checks for > `auth_client_required eq 'cephx'` by reading ceph.conf directly. When > this setting is absent from ceph.conf (relying on the Ceph default, or > configured via the mon config database instead), the check evaluates as > `undef eq 'cephx'` which is false, causing PVE to skip creating the > bootstrap keyring. ceph-volume then fails because it cannot find > /var/lib/ceph/bootstrap-osd/ceph.keyring. > > This can happen when: > - ceph.conf [global] was created before `pveceph init` wrote the auth > settings (pveceph init skips writing them if [global] already exists) > - auth settings were moved from ceph.conf to the mon config database > - an upgrade or migration left ceph.conf without the auth lines > > Fix by defaulting to 'cephx' when the setting is absent (matching > Ceph's own default) and inverting the check to only skip keyring > creation when auth is explicitly set to 'none'. > > Signed-off-by: Kefu Chai > Signed-off-by: Kefu Chai > --- > PVE/API2/Ceph/OSD.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm > index a952c952..062729ae 100644 > --- a/PVE/API2/Ceph/OSD.pm > +++ b/PVE/API2/Ceph/OSD.pm > @@ -407,7 +407,7 @@ __PACKAGE__->register_method({ > > if ( > !-f $ceph_bootstrap_osd_keyring > - && $ceph_conf->{global}->{auth_client_required} eq 'cephx' > + && ($ceph_conf->{global}->{auth_client_required} // 'cephx') ne 'none' As the same variable is already accessed in the line above without a fallback, it either has to be already always defined and this // 'cephx' is superfluous, or we should pull that out upfront and use it for both, like: my $auth_client_required = $ceph_conf->{global}->{auth_client_required} // 'cephx'; (disclaimer, I did not review within the full code context, only found above pattern slightly odd) > ) { > my $bindata = $rados->mon_command({ > prefix => 'auth get-or-create',