From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7B0479EFB for ; Wed, 27 Apr 2022 11:21:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 792542477B for ; Wed, 27 Apr 2022 11:21:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E546824770 for ; Wed, 27 Apr 2022 11:21:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B7BBB42158 for ; Wed, 27 Apr 2022 11:21:34 +0200 (CEST) Message-ID: <408a5f27-d0e4-4d50-af50-b9e2cfead7f7@proxmox.com> Date: Wed, 27 Apr 2022 11:21:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Content-Language: en-US To: Proxmox VE development discussion , Stefan Sterz References: <20220224142151.3206908-1-s.sterz@proxmox.com> <20220224142151.3206908-4-s.sterz@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220224142151.3206908-4-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.955 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.857 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 4/4] parse vm config: remove "\s*" from multi-line comment regex X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2022 09:21:40 -0000 On 24.02.22 15:21, Stefan Sterz wrote: > To be consistent with PBS's implementation of multi-line comments > remove "\s*" here too. Since the regex isn't lazy .* matches > everything \s* would anyway. (Note that new lines occurs after "$"). > > Signed-off-by: Stefan Sterz > --- > PVE/QemuServer.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 243c2e5..79900e8 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -1,4 +1,4 @@ > -package PVE::QemuServer; > +rpackage PVE::QemuServer; ^^^^ seems you fell on the keyboard there ;-) followed that up in git