From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1F30D8D5FD for ; Tue, 8 Nov 2022 16:31:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0164BA086 for ; Tue, 8 Nov 2022 16:31:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 8 Nov 2022 16:31:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3154C42B1F for ; Tue, 8 Nov 2022 16:31:11 +0100 (CET) Message-ID: <407a5788-14e9-dfd8-e887-ecd000c7683d@proxmox.com> Date: Tue, 8 Nov 2022 16:31:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion , Stefan Sterz References: <20221108150130.2415229-1-s.sterz@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221108150130.2415229-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v1 1/2] fix #4328: make help buttons in the markdown editor window work again X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2022 15:31:12 -0000 Am 08/11/2022 um 16:01 schrieb Stefan Sterz: > when the `onlineHelp` of a component is defined in the widget toolkit > `asciidoc-pve` can't pick up on that and `OnlineHelpInfo.js` won't > contain the necessary keys. this patch sets `onlineHelp` in this > package again to avoid that. > > note: technically it would be enough to set this for one of the three > usages of `pmxNotesView`, as then `asciidoc-pve` would add it to > `OnlineHelpInfo.js` again. however, for consistency's sake i added it > to all occurrences. > > Signed-off-by: Stefan Sterz > --- > so this issue doesn't only affect the markdown notes, there are also > other components affected by this. afict this includes: > > * `proxmoxNodeNetworkView`: needs `sysadmin_network_configuration`, > which works because it is also set in `node/Config.js`, similar to > this fix. > * several components related to tfa need `user_mgmt` which are all > currently broken, because that key isn't used at all in > `pve-manager`. > > i think it would be nice to have a solution that allows setting such > keys in the widget toolkit only, but that would require one of two > changes: > > 1. always add all possible keys to `OnlineHelpInfo.js`. to my > understanding, this is similar to how pbs currently creates its > `OnlineHelpInfo.js` > 2. include the widget toolkit's javascript files in the input to > `asciidoc-pve`. however, i am unsure how we could do so elegantly. please go for 2., I'd do so by adding proxmox-widget-toolkit to the Build-Depends list in d/control and parse it from the file at /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js