From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A22B38915C for ; Mon, 17 Oct 2022 16:29:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8D5AE20554 for ; Mon, 17 Oct 2022 16:29:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 17 Oct 2022 16:29:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CB14C4489C; Mon, 17 Oct 2022 16:29:55 +0200 (CEST) Message-ID: <405e30e7-cc17-1522-f73e-57df48fc7f13@proxmox.com> Date: Mon, 17 Oct 2022 16:29:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Thunderbird/106.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20220706130126.282308-1-a.lauterer@proxmox.com> <20220706130126.282308-2-a.lauterer@proxmox.com> From: Dominik Csapak In-Reply-To: <20220706130126.282308-2-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH widget-toolkit v2 1/4] ObjectGrid: optionally show loading mask on load X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2022 14:29:56 -0000 as talked off-list, we can omit the whole patch by using the rstore.load()'s callback directly (we already have to go into the internals of the objectgrid there, so we can use 'rstore.load()' directly too instead of 'reload') On 7/6/22 15:01, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > > changes since v1: > - added description in the documention at the top > - renamed paramter to "maskOnLoad" as I couldn't come up with something > more fitting ;) > > src/grid/ObjectGrid.js | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/src/grid/ObjectGrid.js b/src/grid/ObjectGrid.js > index b355d6d..065a009 100644 > --- a/src/grid/ObjectGrid.js > +++ b/src/grid/ObjectGrid.js > @@ -39,6 +39,8 @@ disabled:: setting this parameter to true will disable selection and focus on > the proxmoxObjectGrid as well as greying out input elements. Useful for a > readonly tabular display > > +maskOnLoad: if set to true, will show a "Loading..." while the store is loading data > + > */ > Ext.define('Proxmox.grid.ObjectGrid', { > extend: 'Ext.grid.GridPanel', > @@ -48,6 +50,8 @@ Ext.define('Proxmox.grid.ObjectGrid', { > // see top-level doc-comment above for details/example > gridRows: [], > > + maskOnLoad: false, > + > disabled: false, > hideHeaders: true, > > @@ -221,7 +225,10 @@ Ext.define('Proxmox.grid.ObjectGrid', { > > reload: function() { > let me = this; > - me.rstore.load(); > + if (me.maskOnLoad) { > + me.setLoading(); > + } > + me.rstore.load({ callback: () => me.setLoading(false) }); > }, > > getObjectValue: function(key, defaultValue) {