From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 3F5C81FF13E
	for <inbox@lore.proxmox.com>; Fri, 06 Mar 2026 11:50:56 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 152781EC03;
	Fri,  6 Mar 2026 11:52:01 +0100 (CET)
Date: Fri, 6 Mar 2026 11:51:23 +0100
From: Gabriel Goller <g.goller@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [PATCH pve-network v3 2/9] test: add test for frr.conf.local
 merging
Message-ID: <3vvb7rh63e44vzh5hpw7sdqnsn35osodf2spmj3nnmfsn4rjuy@4uoc7lxcm7xg>
Mail-Followup-To: Stefan Hanreich <s.hanreich@proxmox.com>,
	pve-devel@lists.proxmox.com
References: <20260305100331.80741-1-g.goller@proxmox.com>
 <20260305100331.80741-12-g.goller@proxmox.com>
 <f0b69b9a-c2b2-4dc1-a76c-7b8f34c8841b@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <f0b69b9a-c2b2-4dc1-a76c-7b8f34c8841b@proxmox.com>
User-Agent: NeoMutt/20241002-35-39f9a6
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1772794255777
X-SPAM-LEVEL: Spam detection results:  0
	AWL                    -1.056 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	RCVD_IN_MSPIKE_H2       0.001 Average reputation (+2)
	RCVD_IN_VALIDITY_CERTIFIED_BLOCKED  0.617 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_RPBL_BLOCKED  0.892 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_SAFE_BLOCKED  0.622 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: 2ADFVMKNO2BZLPZRKMKYTIGKE36XT33I
X-Message-ID-Hash: 2ADFVMKNO2BZLPZRKMKYTIGKE36XT33I
X-MailFrom: g.goller@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On 06.03.2026 10:27, Stefan Hanreich wrote:
> as we discussed off-list:
> We should have a section in this test-case for every supported line by
> the old conf.local parser. One that extends an existing section (if we
> generate one in the SDN stack) and one that adds a new section of the
> respective type. E.g. VRFs and ipv6 prefix-lists are completely missing.

Done, thanks for the review!