From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 019811FF138 for ; Wed, 18 Feb 2026 10:54:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6815317053; Wed, 18 Feb 2026 10:54:58 +0100 (CET) Date: Wed, 18 Feb 2026 10:54:22 +0100 From: Gabriel Goller To: Hannes Laimer Subject: Re: [PATCH pve-network] sdn: controller: prevent invalid router-id generation from zero mac Message-ID: <3stymqcvqw3kryvopo7adntrpnwxpnijrhehag6ggalnkie2yl@ksc45ja7t6qk> Mail-Followup-To: Hannes Laimer , pve-devel@lists.proxmox.com References: <20260213063844.2486-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260213063844.2486-1-h.laimer@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771408454432 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: H2VDC4ADR2ZPY62XMD4DONIBRMGYNDF4 X-Message-ID-Hash: H2VDC4ADR2ZPY62XMD4DONIBRMGYNDF4 X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 13.02.2026 07:38, Hannes Laimer wrote: > When a standard loopback interface is used, the retrieved MAC is > typically 00:00:00:00:00:00. This causes the router-id generation logic > to produce "0.0.0.0", which is an invalid BGP ID. > > Explicitly check for a zero MAC address and fail with a descriptive > error. > > Signed-off-by: Hannes Laimer > --- LGTM! Consider: Reviewed-by: Gabriel Goller > src/PVE/Network/SDN/Controllers/Plugin.pm | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/PVE/Network/SDN/Controllers/Plugin.pm b/src/PVE/Network/SDN/Controllers/Plugin.pm > index d70e518..54d6402 100644 > --- a/src/PVE/Network/SDN/Controllers/Plugin.pm > +++ b/src/PVE/Network/SDN/Controllers/Plugin.pm > @@ -118,6 +118,11 @@ sub get_router_id { > > die "can't autofind a router-id value from ip or mac" if !$mac; > > + if ($mac eq '00:00:00:00:00:00') { > + die "Interface $iface has a zero MAC address. Cannot derive a BGP router-id. " > + . "Please use a dummy interface or assign an IPv4 address to $iface.\n"; > + } > + > my @mac_bytes = split(':', $mac); > return > hex($mac_bytes[2]) . "." > -- > 2.47.3